fix not in good standing staff change business information #78
Conversation
|
/gcbrun |
BrandonSharratt
requested review from
hfekete,
severinbeauvais and
patrickpeinanw
|
Temporary Url for review: https://business-dashboard-dev--pr-78-cn2he8w8.web.app SB says, try this: https://business-dashboard-dev--pr-78-cn2he8w8.web.app/BC0870818 |
| if (!currentBusiness.value.goodStanding) { | ||
| // todo: add staff exclusion. Staff should not be allowed to skip rules for business | ||
| // as if this is enabled, and not in good standing, only thing that will come is popup warning | ||
| if (!currentBusiness.value.goodStanding && !hasRoleStaff) { |
There was a problem hiding this comment.
I'm confused by the logic: "if the business is not in good standing and this isn't staff then don't disable the action" ?
Also, please compare your temporary URL with the dev one -- specifically, click on View and Change Business Information. Why do I see the voluntary dissolution dialog?
Note that, in Dev, View and Change Business Information is enabled when I am staff - see https://dev.business.bcregistry.gov.bc.ca/BC0870818/.
There was a problem hiding this comment.
This logic is pulled right out of business-filings-ui https://github.com/bcgov/business-filings-ui/blob/29cc2f6b204f3755ad13eafd45aa4e524337b071/src/components/EntityInfo/EntityMenu.vue#L400
The example you sent is allowed because the staff user falls into the base case return !this.isAllowed(AllowableActions.BUSINESS_INFORMATION)
*Issue:*bcgov/entity#24459
Description of changes:
Changed the function to not allow staff to change business info on not in good standing businesses
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).