Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix not in good standing staff change business information #78

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix not in good standing staff change business information #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/components/bcros/businessDetails/Links.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ const isPendingDissolution = computed(() => {
})

const isChangeBusinessInfoDisabled = computed(() => {
if (!currentBusiness.value.goodStanding) {
// todo: add staff exclusion. Staff should not be allowed to skip rules for business
// as if this is enabled, and not in good standing, only thing that will come is popup warning
if (!currentBusiness.value.goodStanding && !hasRoleStaff) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused by the logic: "if the business is not in good standing and this isn't staff then don't disable the action" ?

Also, please compare your temporary URL with the dev one -- specifically, click on View and Change Business Information. Why do I see the voluntary dissolution dialog?

Note that, in Dev, View and Change Business Information is enabled when I am staff - see https://dev.business.bcregistry.gov.bc.ca/BC0870818/.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic is pulled right out of business-filings-ui https://github.com/bcgov/business-filings-ui/blob/29cc2f6b204f3755ad13eafd45aa4e524337b071/src/components/EntityInfo/EntityMenu.vue#L400

The example you sent is allowed because the staff user falls into the base case return !this.isAllowed(AllowableActions.BUSINESS_INFORMATION)

return false
}

Expand Down