Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix which modal shows #81

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Fix which modal shows #81

merged 4 commits into from
Nov 26, 2024

Conversation

BrandonSharratt
Copy link
Collaborator

*Issue:*bcgov/entity#24459
#78

Description of changes:
Change the condition for the modal to include staff when not in good standing to fix which dialog shows

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@severinbeauvais
Copy link
Collaborator

/gcbrun

@bcregistry-sre
Copy link
Collaborator

bcregistry-sre commented Nov 26, 2024

@severinbeauvais
Copy link
Collaborator

I'm still seeing this when I click View and Change Business Information:

image

@BrandonSharratt
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-dashboard-dev--pr-81-mj3bn1kv.web.app

@severinbeauvais
Copy link
Collaborator

I'm still seeing this when I click View and Change Business Information:

Hey, it works now.

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you have a broken test.

@BrandonSharratt BrandonSharratt merged commit bda7cc6 into bcgov:main Nov 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants