-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix which modal shows #81
Conversation
/gcbrun |
Temporary Url for review: https://business-dashboard-dev--pr-81-mj3bn1kv.web.app SB says, try this: https://business-dashboard-dev--pr-81-mj3bn1kv.web.app/BC0870818 |
/gcbrun |
Temporary Url for review: https://business-dashboard-dev--pr-81-mj3bn1kv.web.app |
Hey, it works now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but you have a broken test.
*Issue:*bcgov/entity#24459
#78
Description of changes:
Change the condition for the modal to include staff when not in good standing to fix which dialog shows
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).