ZarrArray: add a method to get the DimensionSeparator
#32
Conversation
Without this change, several of the test classes were not run because the class name did not match the default Surefire naming: https://maven.apache.org/surefire-archives/surefire-3.0.0-M5/maven-surefire-plugin/examples/inclusion-exclusion.html ZarrArrayTest_dimensionSeparator is one example of an affected test.
This allows the array's `DimensionSeparator` to be easily checked. The corresponding test is also updated to use the new getter instead of reflective access.
|
Dear Melissa, many thanks for your pull request! I would like to keep the public API as small as possible. Of course then the test is easier to implement and easier to understand, but is there a real use case, really a need for such a public getter method? One of my API design principles is to implement an API along real use cases, not to simplify tests. So I'm very excited to see a presentation of a corresponding use case. I look forward to receive your reply. Best Regards |
SabineEmbacher
changed the base branch from
master
to
getter-for-dimensionseparator
|
Many thanks for this pull request! |
|
@SabineEmbacher: thank you for considering these changes. My immediate use case is to be able to directly test that a I understand that is still just simplifying tests, but as a downstream API consumer it is much easier to be able to call a getter when needed rather than using reflection to access a private field or having to infer the dimension separator based upon which files exist on disk. I appreciate the goal of keeping the API small, but |
|
@SabineEmbacher : I see this pull request was merged, but not in the |
|
@melissalinkert |
3a4e7dd adds a simple getter to
ZarrArrayto retrieve theDimensionSeparator. It also updates the dimension separator test to use the new getter.When updating the dimension separator test, I noticed that some of the tests were not being run. b4eed70 fixes it so that every test class is run.