ZarrArray: add a method to get the DimensionSeparator
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, several of the test classes were not run because the class name did not match the default Surefire naming: https://maven.apache.org/surefire-archives/surefire-3.0.0-M5/maven-surefire-plugin/examples/inclusion-exclusion.html ZarrArrayTest_dimensionSeparator is one example of an affected test.
This allows the array's `DimensionSeparator` to be easily checked. The corresponding test is also updated to use the new getter instead of reflective access.
|
Thanks, @melissalinkert. I resolved the conflict with the ongoing changes from getting things to maven central. |
|
Re-opening to test against build.yml |
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See bcdev#32
3a4e7dd adds a simple getter to
ZarrArrayto retrieve theDimensionSeparator. It also updates the dimension separator test to use the new getter.When updating the dimension separator test, I noticed that some of the tests were not being run. b4eed70 fixes it so that every test class is run.