Update jzarr to 0.3.5 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches from GS snapshot to 0.3.5, which is the current latest version.
The API for specifying nested chunks is slightly different, so this isn't just a version bump. While the separator can easily be set when creating an array, there is no API method to get the array's separator after the fact. Tests here now check for the existence of the first chunk file (which has a hard-coded path), but we could do something like what the jzarr tests do instead:
https://github.com/bcdev/jzarr/blob/0.3.5/src/test/java/com/bc/zarr/ZarrArrayTest_dimensionSeparator.java#L94
raw2ometiff will need a similar treatment (started on https://github.com/glencoesoftware/raw2ometiff/compare/master...melissalinkert:jzarr-version?expand=1), but not until this is in a released version of bioformats2raw.