-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL headline block #1799
Comments
Blocked on adding Nassim Persian to Simorgh: #1910 |
No longer blocked on #1910; now blocked on BBC-archive/psammead#543 |
The above issue was closed, assuming this is now unblocked so we should try to pick up. |
I believe that other than the bolding everything for this is already done. |
Blocked pending #2732 |
Headline (H1) type sizes: |
Unblocked following that BBC-archive/psammead#1516 |
Blocked pending #2713 |
I believe this could be worked on side by side with #2713 removing the blocked label |
Checked as per the description and per the values specified here by @nataliesmart and everything seems to check off, both on Chrome and Firefox. Further UX review is welcomed. |
Headline block looks ok on all four services, font render issue of Urdu on mobile (This is a known issue on iOS) @nataliesmart |
@stevencava What's the Urdu iOS issue? |
Mine doesn't do that once Nassim has loaded. |
When I tap the refresh button it corrects itself |
Then I think we're happy with this :) |
Just noticed it seems to do it when off wifi |
What we're seeing as 'stretched' is the iOS default font, which will display if you've not managed to download Nassim quickly enough - from second page view Nassim should have successfully loaded. |
Closing this issue as we believe the treatment on live is as expected, please reopen if not. |
I have also just checked this and all seems ok on my Chrome Version 76.0.3809.100. Thanks everyone. |
Is your feature request related to a problem? Please describe.
We want our headline block to work for RTL articles (Persian, Arabic, Urdu, Pashto).
Describe the solution you'd like
As a result of #2713, the NassimPersian font should be loaded for all 4 services and we should already have the text direction being right-to-left. This ticket is to ensure that the implementation matches the designs (except for it not using the correct service-specific font).
If the font sizes and line heights need updating, they should be discussed with UX design before implementing any changes
gel-foundations
For each service we should import the Arabic typography settings from here:
import { arabic } from '@bbc/gel-foundations/scripts'
Testing notes
Testing URL's
https://www.test.bbc.com/arabic/articles/c69dvq19k63o
https://www.test.bbc.com/persian/articles/c4vlle3q337o
https://www.test.bbc.com/urdu/articles/cx621klkm1ro
https://www.test.bbc.com/pashto/articles/cng0e8v85eko
Dev insight: Update relevant unit tests.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: