Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Nassim fonts for Persian #1910

Closed
sareh opened this issue Jun 12, 2019 · 5 comments · Fixed by #2549
Closed

Use Nassim fonts for Persian #1910

sareh opened this issue Jun 12, 2019 · 5 comments · Fixed by #2549
Assignees
Labels
blocked This issue should not be worked on until another internal issue is completed - see desc for details high-priority ws-articles Tasks for the WS Articles Team

Comments

@sareh
Copy link
Contributor

sareh commented Jun 12, 2019

Is your feature request related to a problem? Please describe.

As a user of BBC News Persian
I want to be able to read the text on the page
So that I can consume the content

As a user of BBC News Persian
I don't want to load font files for small amounts of text in other scripts
So that I don't use bandwidth unecessarily

Given I am on a Persian article
When I see text in Farsi
Then it is displayed in the BBC Nassim Persian font

Given I am on a Persian article
And there is a fragment in Farsi with a bold attribute
Then I see that fragment in BBC Nassim Persian bold

Given I am on a Persian article
And there is a fragment or other text in a Latin script
Then that text is displayed in the system sans font
And not in BBC Reith Latin

Describe the solution you'd like

Test article: http://localhost.bbc.com:7080/persian/articles/c4vlle3q337o

Describe alternatives you've considered
N/A

Testing notes
Requires manual testing across page types and browsers - specifically older supported browsers.
Fonts should be loaded on both canonical and amp pages, with no errors in the console.

Dev insight: Cypress integration tests & snapshot tests should be added/updated.

@sareh sareh added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-articles Tasks for the WS Articles Team articles-next-epic labels Jun 12, 2019
@12 12 mentioned this issue Jun 21, 2019
2 tasks
@sareh sareh added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Jun 21, 2019
@sareh
Copy link
Contributor Author

sareh commented Jun 21, 2019

Blocked on this issue to add the font-faces to @bbc/psammead-styles BBC-archive/psammead#675

@sareh
Copy link
Contributor Author

sareh commented Jun 21, 2019

Blocked on this work to add this font domain to the CSP header list https://github.com/bbc/simorgh-infrastructure/issues/513

This was referenced Jun 24, 2019
@sareh sareh added high-priority and removed Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. labels Jun 25, 2019
@ryanmccombe ryanmccombe self-assigned this Jun 25, 2019
@sareh
Copy link
Contributor Author

sareh commented Jun 26, 2019

Note: the Mozart Headers have been deployed up to test (Mozart Routing Release 1240) but not yet to live. So any PR relating to this issue should not be merged until that has been deployed first - otherwise we'll have console errors on the Live environment.

@ryanmccombe
Copy link
Contributor

@sadickisaac is already working on this as part of this issue: BBC-archive/psammead#543

Closing this

@dr3
Copy link
Contributor

dr3 commented Jul 12, 2019

This issue was closed prematurely, however ive made #2503 to do the bit that was missing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue should not be worked on until another internal issue is completed - see desc for details high-priority ws-articles Tasks for the WS Articles Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants