-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Nassim fonts for Persian #1910
Comments
Blocked on this issue to add the font-faces to |
Blocked on this work to add this font domain to the CSP header list https://github.com/bbc/simorgh-infrastructure/issues/513 |
Note: the Mozart Headers have been deployed up to test (Mozart Routing Release 1240) but not yet to live. So any PR relating to this issue should not be merged until that has been deployed first - otherwise we'll have console errors on the Live environment. |
@sadickisaac is already working on this as part of this issue: BBC-archive/psammead#543 Closing this |
This issue was closed prematurely, however ive made #2503 to do the bit that was missing :) |
Is your feature request related to a problem? Please describe.
As a user of BBC News Persian
I want to be able to read the text on the page
So that I can consume the content
As a user of BBC News Persian
I don't want to load font files for small amounts of text in other scripts
So that I don't use bandwidth unecessarily
Given I am on a Persian article
When I see text in Farsi
Then it is displayed in the BBC Nassim Persian font
Given I am on a Persian article
And there is a fragment in Farsi with a bold attribute
Then I see that fragment in BBC Nassim Persian bold
Given I am on a Persian article
And there is a fragment or other text in a Latin script
Then that text is displayed in the system sans font
And not in BBC Reith Latin
Describe the solution you'd like
Use the font-faces for Nassim Persian introduced in Add Nassim font faces to psammead-styles BBC-archive/psammead#675 https://ws-downloads.files.bbci.co.uk/fonts/index.html#NassimPersian
Persian articles should download Nassim Persian font files
The correct font weight should be used on normal text / bold text
There should be no Reith fonts loaded on Persian articles
There should be no Nassim Persian fonts loaded on News articles
You can import the Nassim font faces from the latest version of the
psammead-styles
package: https://github.com/bbc/psammead/pull/676/filesTest article:
http://localhost.bbc.com:7080/persian/articles/c4vlle3q337o
Describe alternatives you've considered
N/A
Testing notes
Requires manual testing across page types and browsers - specifically older supported browsers.
Fonts should be loaded on both canonical and amp pages, with no errors in the console.
Dev insight: Cypress integration tests & snapshot tests should be added/updated.
The text was updated successfully, but these errors were encountered: