-
Notifications
You must be signed in to change notification settings - Fork 54
Update styled components in all packages #713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous typo in const that we can clear whilst making this change
@@ -65,7 +65,7 @@ const helmetFontStyles = { | |||
`, | |||
}; | |||
|
|||
const nessimPersian = `font-family: NassimPersian, Arial, Verdana, Geneva, Helvetica, sans serif`; | |||
const nessimPersian = `font-family: NassimPersian, Arial, Verdana, Geneva, Helvetica, sans serif;`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const nessimPersian = `font-family: NassimPersian, Arial, Verdana, Geneva, Helvetica, sans serif;`; | |
const nassimPersian = `font-family: NassimPersian, Arial, Verdana, Geneva, Helvetica, sans serif;`; |
Also can you check where else this is using the wrong spelling please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 searched a repo and "nessim" only appears in this file - updated it to nassim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready for QA Styled components are used in every component in Psammead The update wasn't denoted as having any breaking changes, but may be worth a quick validation anyway |
@ryanmccombe Does this PR only fixes only this PR bbc/simorgh#1910 or does it update the styles for other services as well? Looking at the |
I have done a regression on the storybook which looks good...all the components using |
@PriyaKR this PR doesn't add the Persian fonts - it was just an initial PR, as having the components using different versions of the the bbc/simorgh#1910 will be resolved in a separate PR once this is merged |
Copying the comment from the dependency PR Note: the Mozart Headers have been deployed up to test (Mozart Routing Release 1240) but not yet to live. So any PR relating to this issue should not be merged until that has been deployed first - otherwise we'll have console errors on the Live environment. |
@PriyaKR The Mozart Routing work is only relevant for the Simorgh application, not for Psammead. This is because it adds Content Security Policy headers for the World Service font domain. So this PR is not dependent on the Mozart Routing work. |
thanks @sareh |
| 0.1.0-alpha.3 | [PR#672](https://github.com/BBC/psammead/pull/672) Add margin to top of unordered list | | ||
| 0.1.0-alpha.2 | [PR#534](https://github.com/BBC/psammead/pull/534) Remove Timestamp padding. | | ||
| 0.1.0-alpha.1 | [PR#486](https://github.com/BBC/psammead/pull/486) Create initial package. | | ||
| 1.0.1 | [PR#713](https://github.com/bbc/psammead/pull/713) Update `styled-components` to 4.3.2 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change has overwritten the 1.0.0 version, so we will need to bump again the Story Promo List
to add another record in the CHANGELOG
.
Dependency for bbc/simorgh#1910
Overall change: Update all the packages that use
styled-components
to use the same, latest, versionCode changes: