Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily use NassimPersian font for Arabic, Pashto, Urdu #2732

Closed
jamesdonoh opened this issue Jul 25, 2019 · 3 comments
Closed

Temporarily use NassimPersian font for Arabic, Pashto, Urdu #2732

jamesdonoh opened this issue Jul 25, 2019 · 3 comments
Assignees
@RayNjeri
Labels
ws-articles Tasks for the WS Articles Team

Comments

@jamesdonoh
Copy link
Contributor

jamesdonoh commented Jul 25, 2019 •
edited by rhenshaw56
Loading

Is your feature request related to a problem? Please describe.
Based on #2503 which was done just for Persian.

Until BBC-archive/psammead#735 is done only the NassimPersian fonts are available in Psammead. As the other Arabic-script sites have the same typography settings as Persian, we should use this font temporarily.

Describe the solution you'd like

  • Similar to how persian does it add the Nassim Persian fontfaces to each of the service configs for Arabic, Urdu and Pashto
  • Check if any changes are required to Storybook in SImorgh

Testing notes

  • unit tests to show that nassim works for those services
  • update snapshots
  • manual regression

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

Additional context
Add any other context or screenshots about the feature request here.
@jamesdonoh jamesdonoh added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-articles Tasks for the WS Articles Team articles-current-epic labels Jul 25, 2019
@jamesdonoh jamesdonoh changed the title Use NassimPersian font for Arabic, Pashto, Urdu Temporarily use NassimPersian font for Arabic, Pashto, Urdu Jul 25, 2019
@jamesdonoh jamesdonoh mentioned this issue Jul 25, 2019
Closed
@jamesdonoh
Copy link
Contributor Author

Blocked on #2503

@jamesdonoh jamesdonoh added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Jul 25, 2019
This was referenced Jul 25, 2019
Closed
Closed
Closed
@rhenshaw56 rhenshaw56 removed Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. blocked This issue should not be worked on until another internal issue is completed - see desc for details labels Jul 29, 2019
@RayNjeri RayNjeri self-assigned this Jul 29, 2019
@RayNjeri RayNjeri mentioned this issue Jul 29, 2019
Closed
3 tasks
@RayNjeri
Copy link
Contributor

@jamesdonoh following work from this PR BBC-archive/psammead#1516, if merged should we revert to using the respective fonts availed for each of the services?? ie

  F_NASSIM_ARABIC_REGULAR
  F_NASSIM_ARABIC_BOLD
  F_NASSIM_PASHTO_REGULAR
  F_NASSIM_PASHTO_BOLD
  F_NASSIM_URDU_REGULAR
  F_NASSIM_URDU_BOLD

@RayNjeri
Copy link
Contributor

Following works on this PR BBC-archive/psammead#1516 there is no need on temporarily using the NassimPersian fonts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RayNjeri RayNjeri

Labels
ws-articles Tasks for the WS Articles Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Temporarily use NassimPersian font for Arabic, Pashto and Urdu services. bbc/simorgh
4 participants
@jimjohnsonrollings @jamesdonoh @rhenshaw56 @RayNjeri