-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
Rename Latin Reith sansItalic to sansRegularItalic according to UX feedback
Update Nassim font family names for clarity
…Persian Update snapshots
…s Ethiopic, Padauk, Shonar Bangla
@sareh I've checked the stacks against UX documentation, it's all looking good. Thanks! |
const nassimArabicFontFamily = `font-family: "BBC Nassim Arabic", Arial, Verdana, Geneva, Helvetica, sans-serif;`; | ||
const nassimPashtoFontFamily = `font-family: "BBC Nassim Pashto", Arial, Verdana, Geneva, Helvetica, sans-serif;`; | ||
const nassimPersianFontFamily = `font-family: "BBC Nassim Persian", Arial, Verdana, Geneva, Helvetica, sans-serif;`; | ||
const nassimUrduFontFamily = `font-family: "BBC Nassim Urdu", Arial, Verdana, Geneva, Helvetica, sans-serif;`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we have to rename all these when/if we get Reith for Arabic-script sites?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll delete all of the Nassim section in this file and create a ReithArabic section below the ReithLatin section. The exports at the bottom of the page for arabic, pashto, persian, urdu will be the same.
|
||
const baseUrlShonarBangla = | ||
'https://ws-downloads.files.bbci.co.uk/fonts/ShonarBangla/v5.91/'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth DRYing up the hostname for maintenance purposes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer not to, since this way it's really easy to copy the url in your browser to check it works as expected with the relevant font file name.
Hi @sareh , The only question I have on this is the declaration for "Noto Sans Ethiopic". On live (e.g. https://www.bbc.com/amharic) and in the spreadsheet it is declared as ""NotoSansEthiopic" - no spaces. I know that some work has been done to the fonts recently so the space characters may now be valid, but I just thought I'd check. I tried to download the font file to do more investigation but got Access Denied. Cheers |
@david-boydell Hi David - |
OK, cool thanks @sareh , this is ready for merge then. |
Resolves #735
Overall change: Creates font-family stacks for all services. Renames Nassim font families to
BBC Nassim Arabic
etc. for clarity and consistency. UpdatessansItalic
tosansRegularItalic
Code changes:
@bbc/psammead-styles/font-families
font-face
declarations for the fonts that will be embedded to@bbc/psammead-styles/fonts
sansItalic
tosansRegularItalic
due to UX feedback - this is a breaking change.