This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
More dependencies bumps #1181
Merged
More dependencies bumps #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 12, 2019 11:12
thekp
added
simorgh-core-stream
dependencies
dr3
approved these changes
Jul 12, 2019
| @@ -17,11 +17,11 @@ | |||
| }, | |||
| "homepage": "https://github.com/bbc/psammead/blob/latest/packages/components/psammead-image-placeholder/README.md", | |||
| "dependencies": { | |||
| "@bbc/psammead-assets": "^0.1.2", | |||
| "@bbc/psammead-styles": "^1.1.2" | |||
| "@bbc/psammead-assets": "^1.0.6", | |||
There was a problem hiding this comment.
Has major bump, any expected changes?
There was a problem hiding this comment.
This is where test should focus their eyes
There was a problem hiding this comment.
Looking at psammead-assets changelog no change is done affecting image placeholder though so would be regression as whole i guess.
jamesbhobbs
approved these changes
Jul 12, 2019
Psammead Assets Changelog
|
|
LGTM. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves n/a
Overall change: bumping, packages changed:
-- locale
-- timestamp
-- brand
-- consent-banner
-- copyright
-- heading
-- image-placeholder
-- inline-link
-- media-indicator
-- section-label
-- sitewidelink
Code changes: