-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
brandTitle: 'BBC Pssammead', | ||
brandUrl: 'https://github.com/bbc/psammead', | ||
brandImage: | ||
'https://user-images.githubusercontent.com/11341355/54079666-af202780-42d8-11e9-9108-e47ea27fddc5.png', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added this as without it you lose the word 'Psammead' from the top left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great locally. ✨ I've just added some comments about updating links in Readmes and tidying up the notes implementation.
Co-Authored-By: dr3 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Works great locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Does this PR solve #266? |
@ChrisBAshton Nope |
Tested locally. All acts as expected except for the amp stories which require a refresh, howeve that was the case before. |
Overall change: Move to storybook 5
Code changes:
'import/no-extraneous-dependencies': 'off'
So, awkward, turns out this never worked... If you go on latest and log
paths
on line 71 ofnode_modules/eslint-plugin-import/lib/rules/no-extraneous-dependencies.js
it logsinstead of what we expected;
I will raise an issue to fix this properly (#340), if possible, but for now theres no harm disabling it as it pretty much already is