Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Storybook with AmpImage #266

Closed
1 task done
sareh opened this issue Jan 8, 2019 · 1 comment
Closed
1 task done

Storybook with AmpImage #266

sareh opened this issue Jan 8, 2019 · 1 comment
Labels
bug Something isn't working shared-components

Comments

@sareh
Copy link
Contributor

sareh commented Jan 8, 2019

Describe the bug
A bug found as a result of this PR: #241

When running Storybook and going on the Amp Img stories, e.g. http://localhost:8080/?selectedKind=Image%20-%20AmpImg&selectedStory=16%3A9%20landscape%20image we get this console error:
errors

To Reproduce
Steps to reproduce the behavior:

  1. git checkout update-image-ampimg && npm run install:packages && npm run storybook
  2. Click on http://localhost:8080/?selectedKind=Image%20-%20AmpImg&selectedStory=16%3A9%20landscape%20image Image should load
  3. click on AmpImg Portrait image story. Image should load. Click on AmpImg Custom image story, Image does not load.
  4. See error in console.

errors

This is likely due to the AMP JavaScript being loaded multiple times.

Expected behavior
The Amp Img examples should load no matter how many times they are clicked on.

Desktop (please complete the following information):

  • OS: Mac OS

  • Browser & Version: Firefox nightly 66.0, Chrome canary 73.0

  • Initially labelled with "bug"

@sareh sareh added the bug Something isn't working label Jan 8, 2019
@sareh sareh added the alpha-3 label Jan 8, 2019
@ChrisBAshton ChrisBAshton mentioned this issue Mar 13, 2019
3 tasks
@sareh sareh added ws-articles Tasks for the WS Articles Team ws-home Tasks for the WS Home Team and removed alpha-3 labels May 20, 2019
@jamesbhobbs jamesbhobbs added shared-components and removed ws-articles Tasks for the WS Articles Team ws-home Tasks for the WS Home Team labels Jul 17, 2019
@sareh
Copy link
Contributor Author

sareh commented Aug 20, 2019

Closed as fixed.

@sareh sareh closed this as completed Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working shared-components
Projects
None yet
Development

No branches or pull requests

2 participants