Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Simorgh Storybook to v5 #1410

Closed
1 task done
sareh opened this issue Mar 13, 2019 · 0 comments · Fixed by #1771
Closed
1 task done

Update Simorgh Storybook to v5 #1410

sareh opened this issue Mar 13, 2019 · 0 comments · Fixed by #1771
Assignees
@12
Labels
Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-articles Tasks for the WS Articles Team

Comments

@sareh
Copy link
Contributor

sareh commented Mar 13, 2019 •
edited by jamesbrumpton
Loading

Is your feature request related to a problem? Please describe.
We should update our Simorgh Storybook from v4 to v5.

Describe the solution you'd like
Update our Simorgh Storybook from v4 to v5, using the Psammead example as reference: BBC-archive/psammead#323

Describe alternatives you've considered
N/A

Testing notes
Regression of Storybook on Simorgh, including making sure that no new errors appear in the console.

Dev insight: Running storybook should work as expected.
@sareh sareh added the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Mar 13, 2019
@sareh sareh added ws-articles Tasks for the WS Articles Team simorgh-core-stream labels May 17, 2019
@12 12 self-assigned this May 22, 2019
@12 12 mentioned this issue May 23, 2019
Merged
4 tasks
@dr3 dr3 closed this as completed in #1771 May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@12 12

Labels
Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-articles Tasks for the WS Articles Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade Storybook to v5 bbc/simorgh
2 participants
@sareh @12