Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --check-only flag to isort #88

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

c-w-feldmann
Copy link
Collaborator

No description provided.

@c-w-feldmann c-w-feldmann added type: bug Something isn't working type: maintenance Improvement of code or keeping the code up to date labels Sep 10, 2024
@c-w-feldmann c-w-feldmann self-assigned this Sep 10, 2024
@c-w-feldmann c-w-feldmann linked an issue Sep 10, 2024 that may be closed by this pull request
@c-w-feldmann c-w-feldmann marked this pull request as ready for review September 10, 2024 13:43
@c-w-feldmann c-w-feldmann merged commit c92225e into main Sep 10, 2024
14 checks passed
@c-w-feldmann c-w-feldmann deleted the 87-isort-is-missing-check-only branch September 10, 2024 14:34
JochenSiegWork pushed a commit that referenced this pull request Sep 20, 2024
JochenSiegWork added a commit that referenced this pull request Sep 23, 2024
* mol2morgan_fingerprint: remove deprecated fp function

    - Remove AllChem.GetMorganFingerprintAsBitVect
      from the code because it is deprecated.
    - Add a test to ensure the bit2atom mapping works
      as intended.

* Error handling sanitize bug (#85)

* fix molsanitize exception error catching

* linting

* isort on other stuff

* Inchitomol (#86)

* fix molsanitize exception error catching

* linting

* isort on other stuff

* add inchitomol element

* Add `--check-only` flag to isort (#88)

* docu: update readme, add image, add feature calc notebook (#90)

* docu: update readme, add image, add feature calc notebook

* readme: add feature calculation example

* readme: add published Molpipeline paper link

* notebooks: add header to feature calculation

* add counted fps to test

---------

Co-authored-by: frederik-sandfort1 <[email protected]>
Co-authored-by: Christian W. Feldmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: maintenance Improvement of code or keeping the code up to date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isort is missing --check-only
2 participants