Error handling sanitize bug #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JochenSiegWork
approved these changes
Sep 10, 2024
| @@ -349,7 +349,7 @@ def transform_single(self, input_value: Any) -> Any: | |||
| elif isinstance(p_element, FilterReinserter): | |||
| iter_value = p_element.transform_single(iter_value) | |||
| except MolSanitizeException as err: | |||
| return InvalidInstance( | |||
| iter_value = InvalidInstance( | |||
There was a problem hiding this comment.
So, the filter didn't work because the pipeline just stopped for an instance (a molecule) in the middle of the pipeline when there was a MolSanitizeException . Good catch!
There was a problem hiding this comment.
Jap... But not sure where this came from and why it was there at all...
JochenSiegWork
pushed a commit
that referenced
this pull request
Sep 20, 2024
* fix molsanitize exception error catching * linting * isort on other stuff
JochenSiegWork
added a commit
that referenced
this pull request
Sep 23, 2024
* mol2morgan_fingerprint: remove deprecated fp function
- Remove AllChem.GetMorganFingerprintAsBitVect
from the code because it is deprecated.
- Add a test to ensure the bit2atom mapping works
as intended.
* Error handling sanitize bug (#85)
* fix molsanitize exception error catching
* linting
* isort on other stuff
* Inchitomol (#86)
* fix molsanitize exception error catching
* linting
* isort on other stuff
* add inchitomol element
* Add `--check-only` flag to isort (#88)
* docu: update readme, add image, add feature calc notebook (#90)
* docu: update readme, add image, add feature calc notebook
* readme: add feature calculation example
* readme: add published Molpipeline paper link
* notebooks: add header to feature calculation
* add counted fps to test
---------
Co-authored-by: frederik-sandfort1 <[email protected]>
Co-authored-by: Christian W. Feldmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error that MolSanitizeErrors are caught but not treated correctly by ErrorHandling