Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when changing between mesh preview tabs with no capture loaded #1

Closed
baldurk opened this issue Feb 27, 2014 · 2 comments
Closed
Labels
Bug A crash, misbehaviour, or other problem

Comments

@baldurk
Copy link
Owner

baldurk commented Feb 27, 2014

Reported via the anonymous crash submission tool. When you don't have a capture loaded in the UI, changing between the mesh preview tabs crashes the application.

@baldurk
Copy link
Owner Author

baldurk commented Feb 27, 2014

Fixed very simply, fix will be in the next release.

@baldurk baldurk closed this as completed Feb 27, 2014
@baldurk baldurk added this to the Release v0.19 milestone Mar 1, 2014
@baldurk
Copy link
Owner Author

baldurk commented Mar 1, 2014

Changed my workflow slightly - while the source isn't public I'm going to leave bugs that aren't fixed in a released build yet open until the next release, but ad an appropriate label.

@baldurk baldurk reopened this Mar 1, 2014
@baldurk baldurk closed this as completed Mar 14, 2014
baldurk added a commit that referenced this issue Feb 16, 2016
* Normal resources have a single memory bind that can be added to frame
  references when the resource is. Sparse resources don't have that easy
  single mapping.
* Calls to MarkResourceFrameReferenced with a 0 ResourceId aren't a
  real problem, but we have to be careful when dirtying resources.
* We don't have to dirty memory that's sparsely bound as we'll dirty it
  as soon as its sparsely bound. We do have to worry about making sure
  that memory is correctly frame referenced.
* To do this command buffers track the sparsemapping structures (will be
  created for all sparse resources) that are referenced underneath them.
  Then at queue submit time the current sparse mapping is iterated and
  all bound memory marked frame referenced.
* For most cases where a buffer is bound or similar, we can directly add
  the sparsemapping from the resource record. For descriptor sets we
  must do this indirectly - by marking any bindframerefs in the descset
  record with a bit indicating that the associated resource is sparse,
  then at submit time when iterating the bindframerefs, taking any with
  the bit set and looking up its record to find the sparsemapping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A crash, misbehaviour, or other problem
Projects
None yet
Development

No branches or pull requests

1 participant