-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup dependencies #629
Cleanup dependencies #629
Conversation
"@ethersproject/abi": "^5.0.1", | ||
"@ethersproject/abstract-signer": "^5.3.0", | ||
"@ethersproject/address": "^5.0.1", | ||
"@ethersproject/bignumber": "^5.2.0", | ||
"@ethersproject/bytes": "^5.0.5", | ||
"@ethersproject/constants": "^5.0.1", | ||
"@ethersproject/contracts": "^5.0.1", | ||
"@ethersproject/hash": "^5.0.6", | ||
"@ethersproject/providers": "^5.0.12", | ||
"@ethersproject/strings": "^5.0.5", | ||
"@ethersproject/units": "^5.0.1", | ||
"@ethersproject/wallet": "^5.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not needed if you import the main package. Any references to them in the code still works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome... I think we can just import everything from ethers
then right?
So like instead of:
import { formatUnits } from '@ethersproject/units';
You would write:
import { formatUnits } from 'ethers/lib/utils';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but it seems you can still use the @ethersproject syntax with just the main ethers
package installed. What would be the benefit in going through the project and replacing all the imports?
* develop: [Gnosis]: Add wrap/unwrap transaction action (#636) fix: use more accurate buy/sell amounts for transactions (#635) Add support for transaction speed ups / cancellations (#631) UI 678 lm table (#621) Cleanup dependencies (#629) Disable coingecko list for now (#628) Cleanup unused files & functions (#626) Hotfix/1.11.4 (#627) [Gnosis]: Various bug fixes (#624) Registry refactor hook up (#570) Persist transactions (#620) [Gnosis]: More UI Tweaks (#616)
Description
There were quite a few unused packages so I've removed them.
Type of change
How should this be tested?
Checklist:
master
if hotfix,develop
if not