Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dependencies #629

Merged
merged 12 commits into from
Aug 5, 2021
Merged

Cleanup dependencies #629

merged 12 commits into from
Aug 5, 2021

Conversation

garethfuller
Copy link
Collaborator

@garethfuller garethfuller commented Aug 4, 2021

Description

There were quite a few unused packages so I've removed them.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

How should this be tested?

  • Generally test app functionality.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • My changes generate no new console warnings
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Aug 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/kovan-app/2Dhx3zBV6usZEzhNEjM6hgoMB1nb
✅ Preview: Canceled

[Deployment for 31d320c canceled]

app – ./

🔍 Inspect: https://vercel.com/balancer/app/6meTK6faddSfMhYgpZTAdgLZFRdb
✅ Preview: Canceled

[Deployment for 31d320c canceled]

staging-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-app/4Gsmzm8v4EJsjuYKKkkF257vDDHg
✅ Preview: https://staging-app-git-gareth-remove-pkgs-balancer.vercel.app

staging-kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-kovan-app/7KsBP26WQfwZcoDsxsaVGm2dF13B
✅ Preview: https://staging-kovan-app-git-gareth-remove-pkgs-balancer.vercel.app

gnosis – ./

🔍 Inspect: https://vercel.com/balancer/gnosis/GLTY2m6s5Z7uxSxpz6uwjHnTp7N7
✅ Preview: https://gnosis-git-gareth-remove-pkgs-balancer.vercel.app

polygon – ./

🔍 Inspect: https://vercel.com/balancer/polygon/FotNmwNvAWfzaU2bJZrGwtdniWHm
✅ Preview: https://polygon-git-gareth-remove-pkgs-balancer.vercel.app

beta-polygon – ./

🔍 Inspect: https://vercel.com/balancer/beta-polygon/DXy44QzURRkq5VL28LSwbLM9QwS4
✅ Preview: https://beta-polygon-git-gareth-remove-pkgs-balancer.vercel.app

Comment on lines -27 to -38
"@ethersproject/abi": "^5.0.1",
"@ethersproject/abstract-signer": "^5.3.0",
"@ethersproject/address": "^5.0.1",
"@ethersproject/bignumber": "^5.2.0",
"@ethersproject/bytes": "^5.0.5",
"@ethersproject/constants": "^5.0.1",
"@ethersproject/contracts": "^5.0.1",
"@ethersproject/hash": "^5.0.6",
"@ethersproject/providers": "^5.0.12",
"@ethersproject/strings": "^5.0.5",
"@ethersproject/units": "^5.0.1",
"@ethersproject/wallet": "^5.0.1",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not needed if you import the main package. Any references to them in the code still works.

Copy link
Contributor

@evgenyboxer evgenyboxer Aug 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome... I think we can just import everything from ethers then right?

So like instead of:
import { formatUnits } from '@ethersproject/units';
You would write:
import { formatUnits } from 'ethers/lib/utils';

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but it seems you can still use the @ethersproject syntax with just the main ethers package installed. What would be the benefit in going through the project and replacing all the imports?

@garethfuller garethfuller merged commit 232d921 into develop Aug 5, 2021
@garethfuller garethfuller deleted the gareth/remove-pkgs branch August 5, 2021 07:56
TomAFrench added a commit that referenced this pull request Aug 7, 2021
* develop:
  [Gnosis]: Add wrap/unwrap transaction action (#636)
  fix: use more accurate buy/sell amounts for transactions (#635)
  Add support for transaction speed ups / cancellations (#631)
  UI 678 lm table (#621)
  Cleanup dependencies (#629)
  Disable coingecko list for now (#628)
  Cleanup unused files & functions (#626)
  Hotfix/1.11.4 (#627)
  [Gnosis]: Various bug fixes (#624)
  Registry refactor hook up (#570)
  Persist transactions (#620)
  [Gnosis]: More UI Tweaks (#616)
This was referenced Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants