-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist transactions #620
Persist transactions #620
Conversation
return fallback || {}; | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved into lsGet
and refactored (I'm not a fan of returning an empty object - better return something like null
)
} | ||
} | ||
|
||
return defaultValue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If provided with version
it will try to get the data of that version and will always return the defaultValue
in case of a mismatch (for version upgrades)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the local storage logic could probably be extracted into a service now. Would make it cleaner and more self-contained. I'm not suggesting it needs to be part of this PR though.
Yeah, good idea - a chance to make it much nicer and cleaner. |
* develop: [Gnosis]: Add wrap/unwrap transaction action (#636) fix: use more accurate buy/sell amounts for transactions (#635) Add support for transaction speed ups / cancellations (#631) UI 678 lm table (#621) Cleanup dependencies (#629) Disable coingecko list for now (#628) Cleanup unused files & functions (#626) Hotfix/1.11.4 (#627) [Gnosis]: Various bug fixes (#624) Registry refactor hook up (#570) Persist transactions (#620) [Gnosis]: More UI Tweaks (#616)
Description
Added persistence to notifications by adding a version
version
prop tolsGet
andlsSet
.Fixes # (issue)
Type of change
How should this be tested?
Please provide instructions so we can test. Please also list any relevant details for your test configuration.
Checklist:
master
if hotfix,develop
if not