-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registry refactor hook up #570
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arb000r
approved these changes
Aug 3, 2021
TomAFrench
added a commit
that referenced
this pull request
Aug 7, 2021
* develop: [Gnosis]: Add wrap/unwrap transaction action (#636) fix: use more accurate buy/sell amounts for transactions (#635) Add support for transaction speed ups / cancellations (#631) UI 678 lm table (#621) Cleanup dependencies (#629) Disable coingecko list for now (#628) Cleanup unused files & functions (#626) Hotfix/1.11.4 (#627) [Gnosis]: Various bug fixes (#624) Registry refactor hook up (#570) Persist transactions (#620) [Gnosis]: More UI Tweaks (#616)
This was referenced Aug 24, 2021
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hooking up the new token related composables throughout the app. Apologies for this ridiculously large PR, it was difficult to do it in smaller chunks.
When reviewing, because there are so many changes, it's best if you just look at files / areas of the app you are familiar with. Also, below is a list of the key files that make up the new tokens system.
In general, it's best if you review by testing as much of the app functionality as possible and then reviewing files when you find bugs.
Queries
Providers
Other important changes
Type of change
How should this be tested?
Checklist:
master
if hotfix,develop
if not