Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry refactor hook up #570

Merged
merged 55 commits into from
Aug 3, 2021
Merged

Registry refactor hook up #570

merged 55 commits into from
Aug 3, 2021

Conversation

garethfuller
Copy link
Collaborator

@garethfuller garethfuller commented Jul 15, 2021

Description

Hooking up the new token related composables throughout the app. Apologies for this ridiculously large PR, it was difficult to do it in smaller chunks.

When reviewing, because there are so many changes, it's best if you just look at files / areas of the app you are familiar with. Also, below is a list of the key files that make up the new tokens system.

In general, it's best if you review by testing as much of the app functionality as possible and then reviewing files when you find bugs.

Queries

Providers

Other important changes

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

How should this be tested?

  • Generally test all core functionality is working as expected. In particular all different types of trades (incl. Gnosis), investing/withdrawing and token search functionality.
  • Test injecting a token via address in token search modal
  • Test trade interface deep links

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • My changes generate no new console warnings
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Jul 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/kovan-app/9G7xt2o72PthpqWxQs31D4A4iWKH
✅ Preview: Canceled

[Deployment in progress for 8f0b214]

app – ./

🔍 Inspect: https://vercel.com/balancer/app/Gz7hqLtKPoC4vrb2cBU192CvvM3Q
✅ Preview: Canceled

[Deployment for 8f0b214 canceled]

staging-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-app/JC3VH7ZfxEA36kDCSKw1Uxu2G7ck
✅ Preview: https://staging-app-git-gareth-registry-refactor-balancer.vercel.app

polygon – ./

🔍 Inspect: https://vercel.com/balancer/polygon/E9bB4zSm3wHSM7m1XCGk7xbCT1eP
✅ Preview: https://polygon-git-gareth-registry-refactor-balancer.vercel.app

staging-kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-kovan-app/hVz6FiPQyg6GAgfshY5vKwSyVcHL
✅ Preview: https://staging-kovan-app-git-gareth-registry-refactor-balancer.vercel.app

gnosis – ./

🔍 Inspect: https://vercel.com/balancer/gnosis/HEzwYWk1nVY2JyFHKjrCfrewgTou
✅ Preview: https://gnosis-git-gareth-registry-refactor-balancer.vercel.app

beta-polygon – ./

🔍 Inspect: https://vercel.com/balancer/beta-polygon/2Mo9fLkpJrtRp9HVmHhMgN59BHTr
✅ Preview: https://beta-polygon-git-gareth-registry-refactor-balancer.vercel.app

@vercel vercel bot temporarily deployed to Preview – kovan-app August 3, 2021 14:30 Inactive
@vercel vercel bot temporarily deployed to Preview – app August 3, 2021 14:30 Inactive
@garethfuller garethfuller merged commit 2d3d57b into develop Aug 3, 2021
@garethfuller garethfuller deleted the gareth/registry-refactor branch August 3, 2021 14:46
TomAFrench added a commit that referenced this pull request Aug 7, 2021
* develop:
  [Gnosis]: Add wrap/unwrap transaction action (#636)
  fix: use more accurate buy/sell amounts for transactions (#635)
  Add support for transaction speed ups / cancellations (#631)
  UI 678 lm table (#621)
  Cleanup dependencies (#629)
  Disable coingecko list for now (#628)
  Cleanup unused files & functions (#626)
  Hotfix/1.11.4 (#627)
  [Gnosis]: Various bug fixes (#624)
  Registry refactor hook up (#570)
  Persist transactions (#620)
  [Gnosis]: More UI Tweaks (#616)
This was referenced Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants