Fixes race conditions in HubDeviceSelect. #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were problematic when the shutdown/close happened on a different thread than the executor. Caused flakey tests.
bakerstu
approved these changes
Aug 20, 2024
| bool completed = false; | ||
| while (!completed) | ||
| { | ||
| executor()->sync_run([this, &completed]() { |
| // This is a workaround that sometimes my linux kernel gets stuck in | ||
| // ::read when I closed the fd like this, even though the fd is | ||
| // O_NONBLOCK. | ||
| executor()->add(new CallbackExecutable([this, fd]() { |
atanisoft
added a commit
to atanisoft/OpenMRNIDF
that referenced
this pull request
Aug 20, 2024
balazsracz
added a commit
that referenced
this pull request
Aug 20, 2024
balazsracz
added a commit
that referenced
this pull request
Jan 16, 2025
* master: (76 commits) Fixes some compile errors in nucleo and bracz.acc. ESP-IDF CMakeLists (#800) BLE Basic Infrastructure (#788) Handles unhandled-addressed-messages by generating an OIR reply. (#798) Adds factory reset handler to linux:io_board. (#797) Fixes a standards compliance issue with the alias conflict handler. (#793) Bug fixes in DataBuffer (#791) Fixes race conditions in HubDeviceSelect. (#795) Fixes missing translation of enums when reading the security mode from a simplelink profile. (#796) Fixes flaky IfCanStress.test. (#794) Pin esp32 platform to 2.0.x (#792) Fixes detecting EOF in the memory config protocol handler. (#789) Adds a new hub application using DirectHub (#761) High-performance hub component for dealing with many sockets and high throughput (#760) Fix build of esp8266 train implementation. Removes unnecessary includes that might not exist on an embedded compiler. Fix compilation of TempFile under esp8266. Add libatomic to esp8266 nonos target. Fix compile errors in time_client app. Fixes in file memory space: (#786) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were problematic when the shutdown/close happened on a different thread than the executor. Caused flakey tests.
Updates a test helper to use heap memory because that plays nicer with Valgrind's data race checker.