Fixes a standards compliance issue with the alias conflict handler. #793
Conversation
The standard requires that at the time when an alias conflict is detected, the device to issue an AMR frame with the conflicted alias. This PR adds the missing AMR frame. Adjusts tests to heck for this frame. Fixes a bug in the Global AME handler that was unexpectedly emitting AMD frames for removed aliases, because the cache entry was not correctly wiped when the remove was processed, and the iteration also picked up such deleted entries.
src/openlcb/IfCan.cxx
Outdated
| @@ -170,6 +175,37 @@ class AliasConflictHandler : public CanFrameStateFlow | |||
| return exit(); | |||
| } | |||
|
|
|||
| /// Sends an AMR (alias mapping release) frame with the alias alias_ and | |||
| /// the loca node ID that we have for it. Then deletes the mapping from the | |||
There was a problem hiding this comment.
The standard requires that at the time when an alias conflict is detected, the device to issue an AMR frame with the conflicted alias.
This PR adds the missing AMR frame.
The standard says to send the AMR if the alias is for a node in Permitted state. As I read it, if that alias hasn't been used yet to go to Permitted state, it's not really "in use" and you just drop it.
Does this PR do that?
…ate an AMR frame upon conflict.
an AMR frame upon conflict.
There was indeed a bug there. Thanks for flagging! |
* master: (76 commits) Fixes some compile errors in nucleo and bracz.acc. ESP-IDF CMakeLists (#800) BLE Basic Infrastructure (#788) Handles unhandled-addressed-messages by generating an OIR reply. (#798) Adds factory reset handler to linux:io_board. (#797) Fixes a standards compliance issue with the alias conflict handler. (#793) Bug fixes in DataBuffer (#791) Fixes race conditions in HubDeviceSelect. (#795) Fixes missing translation of enums when reading the security mode from a simplelink profile. (#796) Fixes flaky IfCanStress.test. (#794) Pin esp32 platform to 2.0.x (#792) Fixes detecting EOF in the memory config protocol handler. (#789) Adds a new hub application using DirectHub (#761) High-performance hub component for dealing with many sockets and high throughput (#760) Fix build of esp8266 train implementation. Removes unnecessary includes that might not exist on an embedded compiler. Fix compilation of TempFile under esp8266. Add libatomic to esp8266 nonos target. Fix compile errors in time_client app. Fixes in file memory space: (#786) ...
The standard requires that at the time when an alias conflict is detected, the device to issue an AMR frame with the conflicted alias.
This PR adds the missing AMR frame. Adjusts tests to heck for this frame. Fixes a bug in the Global AME handler that was unexpectedly emitting AMD frames for removed aliases, because the cache entry was not correctly wiped when the remove was processed, and the iteration also picked up such deleted entries.