Bug fixes in DataBuffer #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrites conditions in move read pointer forward, because it was incorrect.
- Handles the case when the src or dst buffer is empty. - Detects when the append happens exactly at a buffer boundary and the buffers are already linked buffer. - Adds a parameter that makes this work even when the link is not there yet
This fixes a buffer refcount bug when a buffer ended up with a zero length and too few refs.
We took over o.free_ but this makes the current buffer appendable, which is wrong.
atanisoft
reviewed
Aug 5, 2024
atanisoft
reviewed
Aug 5, 2024
bakerstu
approved these changes
Aug 16, 2024
atanisoft
added a commit
to atanisoft/OpenMRNIDF
that referenced
this pull request
Aug 20, 2024
balazsracz
added a commit
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several corner cases in appending to a Datauffer that were incorrectly handled and causing crashes in DirectHub.
This PR fixes bugs and adds tests including several fuzz tests for databuffers.