Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #280, fixes #277 Remove Layout Builder Customizations #281

Merged
merged 10 commits into from
Sep 11, 2020

Conversation

tadean
Copy link
Contributor

@tadean tadean commented Sep 2, 2020

This PR removes our Layout Builder customizations and replaces them with a placeholder paragraph reference field to prepare for our transition to paragraphs.

Description

Configuration related to our Layout Builder customizations has been removed, paragraphs has been added, and the Page content type has been given a paragraph reference field in order to provide a placeholder for our paragraphs implementations.

Since removing the Layout Builder customizations effectively leaves Page without any way to add content, a simple placeholder paragraph bundle has been added (az_text).

This placeholder implementation follows the same pattern as the D7 implementation: az_content_chunks contains the modules related to the paragraph bundles, and the individual paragraph bundles are submodules inside it, in this case az_content_chunks_text.

The placeholder az_content_chunks module provides library loading functionality such as we originally had on our inline blocks for Layout Builder (ie. it's possible to load CSS and JS for a specific paragraph bundle.) The placeholder az_text bundle has a CSS file defined, not because it's necessary, but just to demonstrate the functionality for furture work.

Display Suite has been removed as it was no longer required for anything, which fixes #277

Flexible pages will have paragraphs available only for the az_content_chunks submodules that are currently enabled.

Related Issue

#280 #277

How Has This Been Tested?

Attempt to create a Flexible Page using the provided paragraph bundle.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I've added this Pull Request to the AZ Quickstart project in the right column.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tadean tadean added the enhancement New feature or request label Sep 2, 2020
@tadean tadean requested a review from a team as a code owner September 2, 2020 00:10
@tadean tadean linked an issue Sep 2, 2020 that may be closed by this pull request
@tadean
Copy link
Contributor Author

tadean commented Sep 2, 2020

image
image

@tadean
Copy link
Contributor Author

tadean commented Sep 2, 2020

A test should ideally be added before merging, as there used to be one present in the layout builder customizations.

@joeparsons
Copy link
Member

Looks like the Deprecated Code check failures are all due to classes extending base classes provided by modules that we don't include in Quickstart. I'm assuming the Entity Reference Revisions and Paragraphs module classes provide optional functionality that is only available if the modules providing the base classes are installed but do you think we should consider adding any of these modules?

  • Diff
  • Entity Browser
  • Feeds

@trackleft
Copy link
Member

  • Diff
  • Entity Browser
  • Feeds

I think I like all of those modules.

@tadean
Copy link
Contributor Author

tadean commented Sep 2, 2020

I'd be open to including those if it squelches the warnings, they all seem like pretty useful utility modules in general to have in our toolkit.

@trackleft
Copy link
Member

trackleft commented Sep 2, 2020

Hey Troy how do you feel about using an object oriented approach to preprocessing paragraphs, as seen in the attached module?
az_components.zip

@tadean
Copy link
Contributor Author

tadean commented Sep 2, 2020

Hey Troy how do you feel about using an object oriented approach to preprocessing paragraphs, as seen in the attached module?
az_components.zip

I like it! I'll update to do something similar.

@tadean
Copy link
Contributor Author

tadean commented Sep 2, 2020

Updated with D9 changes from master.

feeds and entity_browser both have their own deprecation warnings when they're added to the build to attempt to solve the deprecation warnings. FWIW, feeds doesn't have a stable release yet, either. I'll look into if maybe there are any patches floating around that solve the original issues.

@tadean
Copy link
Contributor Author

tadean commented Sep 9, 2020

  • Added basic unit test
  • Switched preprocessing of paragraphs to being in a Drupal service per @trackleft 's suggestion.

trackleft
trackleft previously approved these changes Sep 9, 2020
@tadean
Copy link
Contributor Author

tadean commented Sep 9, 2020

Updated pull request to change the name of az_content_chunks to az_paragraphs.

@tadean tadean requested review from trackleft, joeparsons and a team September 9, 2020 17:55
@tadean
Copy link
Contributor Author

tadean commented Sep 9, 2020

image

joeparsons
joeparsons previously approved these changes Sep 10, 2020
trackleft
trackleft previously approved these changes Sep 10, 2020
@tadean tadean dismissed stale reviews from trackleft and joeparsons via f5da004 September 11, 2020 16:29
@tadean
Copy link
Contributor Author

tadean commented Sep 11, 2020

Updated to change the label of the text area of the placeholder paragraph from AZ Text Area to Text.
image

Updated to change the description/name of the placeholder paragraph bundle module from Plain Text to Text, to support the requirements of the proposed final Text paragraph.
image

@camikazegreen camikazegreen self-requested a review September 11, 2020 17:29
@joeparsons
Copy link
Member

Per 2020-09-09 PR meeting & 2020-09-11 Friday meeting: new deprecation warnings will be addressed in followup issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Layout Builder Customizations Remove Display Suite
3 participants