-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #280, fixes #277 Remove Layout Builder Customizations #281
Conversation
A test should ideally be added before merging, as there used to be one present in the layout builder customizations. |
Looks like the Deprecated Code check failures are all due to classes extending base classes provided by modules that we don't include in Quickstart. I'm assuming the Entity Reference Revisions and Paragraphs module classes provide optional functionality that is only available if the modules providing the base classes are installed but do you think we should consider adding any of these modules?
|
I think I like all of those modules. |
I'd be open to including those if it squelches the warnings, they all seem like pretty useful utility modules in general to have in our toolkit. |
Hey Troy how do you feel about using an object oriented approach to preprocessing paragraphs, as seen in the attached module? |
I like it! I'll update to do something similar. |
Updated with D9 changes from master.
|
|
Updated pull request to change the name of |
Per 2020-09-09 PR meeting & 2020-09-11 Friday meeting: new deprecation warnings will be addressed in followup issue. |
This PR removes our Layout Builder customizations and replaces them with a placeholder paragraph reference field to prepare for our transition to paragraphs.
Description
Configuration related to our Layout Builder customizations has been removed, paragraphs has been added, and the Page content type has been given a paragraph reference field in order to provide a placeholder for our paragraphs implementations.
Since removing the Layout Builder customizations effectively leaves Page without any way to add content, a simple placeholder paragraph bundle has been added (
az_text
).This placeholder implementation follows the same pattern as the D7 implementation:
az_content_chunks
contains the modules related to the paragraph bundles, and the individual paragraph bundles are submodules inside it, in this caseaz_content_chunks_text
.The placeholder
az_content_chunks
module provides library loading functionality such as we originally had on our inline blocks for Layout Builder (ie. it's possible to load CSS and JS for a specific paragraph bundle.) The placeholderaz_text
bundle has a CSS file defined, not because it's necessary, but just to demonstrate the functionality for furture work.Display Suite has been removed as it was no longer required for anything, which fixes #277
Flexible pages will have paragraphs available only for the
az_content_chunks
submodules that are currently enabled.Related Issue
#280 #277
How Has This Been Tested?
Attempt to create a Flexible Page using the provided paragraph bundle.
Types of changes
Checklist: