Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #485 Remove unused CSS files in az_flexible_page module #3892

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

BaoNguyen09
Copy link
Contributor

@BaoNguyen09 BaoNguyen09 commented Nov 19, 2024

Description

I deleted 2 css files: az_flexible_page.css and az_flexible_page_layout.css in az_flexible_page module

Related issues

Closes #485

How to test

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@BaoNguyen09 BaoNguyen09 requested a review from a team as a code owner November 19, 2024 23:39
@BaoNguyen09 BaoNguyen09 linked an issue Nov 19, 2024 that may be closed by this pull request
1 task
@BaoNguyen09 BaoNguyen09 self-assigned this Nov 19, 2024
@BaoNguyen09 BaoNguyen09 changed the title delete 2 unused css file within az_flexible_page module Closes #485 Remove unused CSS files in az_flexible_page module Nov 19, 2024
@joeparsons joeparsons added enhancement New feature or request task Work that doesn't always require a pull request. labels Nov 20, 2024
Copy link
Contributor

@bberndt-uaz bberndt-uaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these files are safe to delete. Here is the history of these two CSS files and AZ Flexible Page libraries:

  1. az_flexible_page.css and az_flexible_page_layout.css were added to the module and defined as assets in az_flexible_page.libraries:

  2. The original az_flexible_page.libraries was deleted and the CSS files were left in the module folder:

  3. az-flexible-page-edit-form.css was added and defined as an asset in a new libraries file:

  4. az_flexible_page.theme.css was added and defined as a second asset in the libraries file:

Copy link
Contributor

@joshuasosa joshuasosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I could see, I don't think these CSS files currently in use. Should be ok to clean up!

@joeparsons joeparsons merged commit 2c68cec into main Nov 22, 2024
16 checks passed
@joeparsons joeparsons deleted the issue/485 branch November 22, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request task Work that doesn't always require a pull request.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove unused CSS files in az_flexible_page module
6 participants