Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Simple Background image formatter module #2685

Closed
joeparsons opened this issue Aug 28, 2023 · 0 comments · Fixed by #2792
Closed

Deprecate Simple Background image formatter module #2685

joeparsons opened this issue Aug 28, 2023 · 0 comments · Fixed by #2792
Assignees
Labels
2.8.x only To be included in the 2.8 minor release only. dependencies Pull requests that update a dependency file Drupal Waiting on a fix from the Drupal community

Comments

@joeparsons
Copy link
Member

joeparsons commented Aug 28, 2023

Motivation

The Simple Background image formatter module that was first added to Quickstart 2 back when we were still experimenting with Layout Builder (in the very early days) is no longer being used by anything in Quickstart so we should consider deprecating it. (and eventually removing it)

We probably should have noticed that the module was no longer being used before forking it to maintain D10 compatibility (see #2354 and #2656) 🤦🏻‍♂️.

Proposed Resolution

  • Deprecate module starting with 2.8.0
    • Add status report warning if module is installed (?)
  • Remove module in 2.9.0
@joeparsons joeparsons added dependencies Pull requests that update a dependency file Drupal Waiting on a fix from the Drupal community 2.8.x only To be included in the 2.8 minor release only. labels Aug 28, 2023
@joeparsons joeparsons moved this from Todo to Needs Review in 2.8.0 Minor Release Oct 5, 2023
@joeparsons joeparsons self-assigned this Oct 6, 2023
@github-project-automation github-project-automation bot moved this from Needs Review to Done in 2.8.0 Minor Release Oct 6, 2023
trackleft added a commit that referenced this issue Oct 6, 2023
…S deprecated modules warning to status report. (#2792)

Co-authored-by: Chris Green <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.8.x only To be included in the 2.8 minor release only. dependencies Pull requests that update a dependency file Drupal Waiting on a fix from the Drupal community
Projects
No open projects
1 participant