Closes #2081: Upgrade Drupal core to 10.0.9

[joeparsons]

Description

• Upgrades Drupal core to 10.0.9
• Adds CKEditor 4 contrib module
• Upgrades various contrib modules to D10-compatible versions (including config_sync/config_distro suite of modules)
• Updates core and contrib patches
• Fixes various issues with tests
  • Replaces usage of seven theme in tests with claro since seven is no longer available in D10
  • Adds new patch for Bootstrap Barrio JS library issue that was causing an error that broke a PHPUnit test
  • Updates usage of str_replace migrate process plugin provided by migrate_plus in various migrations to fix failing migration tests
• Fixes various issues reported by phpstan and PHPCS
• Fixes an issue that @tadean noticed involving once.js that affected the Event Calendar and Publication date picker
• Updates lando and ProboCI configs
• Removes lando/ddev tooling for Drupal console
• Updates phpstan and PHPCS configs
• Replaces drupal/background_image_formatter and drupal/smart_title with az-digital D10-compatible forks

Related PRs

These will need to be merged in conjunction with this one:

• Scaffolding Repo PR: az-digital/az_quickstart#2081: Make scaffolding repo D10 compatible. az-quickstart-scaffolding#104
• Dev Dependencies Metapackage PR: az-digital/az_quickstart#2081: Drupal 10 compatibility changes. az-quickstart-dev#82
• Pantheon Upstream PR: Closes #163, az-digital/az_quickstart#2081 Prepare upstream for Drupal 10 az-quickstart-pantheon#165 (the timing of this one will need to be very specific and probably in conjuction with the final 2.7.0 stable release)

Some of the changes included here are also available in individual PRs where they may be easier to review/test/merge in isolation (and probably should be):

• Closes #2442: Update drupal/bootstrap_barrio from 4.30 to 5.1.10. #2452
• Update drupal/better_exposed_filters requirement from 5.0 to 6.0.3 #1999
• Closes #2321: Update drupal/menu_block requirement from 1.7.0 to 1.10.0 #2325
• #2213: Update drupal/migrate_tools requirement from 5.2.0 to 6.0.1 #2450
• Closes #2486: Remove tooling for Drupal console 😢. #2489

Related issues

Closes #2081

How to test

• General testing
• CKeditor testing

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

• Patch release changes
  • Bug fix
  • Accessibility, performance, or security improvement
  • Critical institutional link or brand change
  • Adding experimental module
  • Update experimental module
• Minor release changes
  • New feature
  • Breaking or visual change to existing behavior
  • Upgrade experimental module to stable
  • Enable existing module by default or database update
  • Non-critical brand change
  • New internal API or API improvement with backwards compatibility
  • Risky or disruptive cleanup to comply with coding standards
  • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
• Other or unknown
  • Other or unknown

Drupal core

• Patch release changes
  • Security update
  • Patch level release (non-security bug-fix release)
  • Patch removal that's no longer necessary
• Minor release changes
  • Major or minor level update
• Other or unknown
  • Other or unknown

Drupal contrib projects

• Patch release changes
  • Security update
  • Patch or minor level update
  • Add new module
  • Patch removal that's no longer necessary
• Minor release changes
  • Major level update
• Other or unknown
  • Other or unknown

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[tadean]

It seems like Storage comparer issue in the removed config_distro patches might still exist (though the patch no longer applies), but I'm not sure...this was for #428 I think . Here is a potentially rerolled patch, though maybe the actual cause could be elsewhere...

[camikazegreen]

When attempting to edit this News article as an Admin or Content Admin, I get this error:

I have verified that this occurs with any News that I have tried to edit, but does not happen for Pages, Events or People.

[joeparsons]

It seems like Storage comparer issue in the removed config_distro patches might still exist (though the patch no longer applies), but I'm not sure...this was for #428 I think . Here is a potentially rerolled patch, though maybe the actual cause could be elsewhere...

Thanks @tadean I've restored the (re-rolled) patch.

[Carris-Toupin]

I checked the CK editor functions as azadmin in a Page and everything works as it should, especially the embed features. Let me know if you want me to test as a specific user or in a specific Content type.

[tadean]

After taking a D9 build and moving it to #2354, a cache clear was required to get the site working again. The following database updates were available:

 ------------------------ ----------- --------------- ---------------------------------------------------------------- 
  Module                   Update ID   Type            Description                                                     
 ------------------------ ----------- --------------- ---------------------------------------------------------------- 
  better_exposed_filters   8003        hook_update_n   8003 - Provide upgrade path from 8.x-4.x to 8.x-5.x.            
  user                     10000       hook_update_n   10000 - Remove non-existent permissions created by migrations.  
 ------------------------ ----------- --------------- ---------------------------------------------------------------- 

The following config_distro changes were present for import:

 ---------------- ---------------- ------------------------------------------------ 
 Extension        Operation type   Label                                           
---------------- ---------------- ------------------------------------------------ 
 az_core          create           Enterprise Thumbnail                            
 az_core          create           Enterprise Thumbnail Small                      
 az_core          create           taxonomy_term.field_az_attribute_type           
 az_core          create           taxonomy_term.field_az_attribute_key            
 az_core          create           node.field_az_enterprise_attributes             
 az_core          create           Enterprise Attributes                           
 az_core          create           Attribute Type                                  
 az_core          create           Attribute Key                                   
 az_core          create           taxonomy_term.az_enterprise_attributes.default  
 az_core          create           taxonomy_term.az_enterprise_attributes.default  
 az_core          create           Taxonomy List Pages                             
 az_core          update           az_core.settings                                
 az_core          update           smart_title.settings                            
 az_media         update           Standard                                        
 az_news          create           Enterprise Attributes                           
 az_news          create           node.az_news.az_row                             
 az_news          update           node.az_news.default                            
 az_news          update           node.az_news.teaser                             
 az_news          update           node.az_news.default                            
 az_news          update           node.az_news.az_minimal_media_list              
 az_news          update           node.az_news.az_medium_media_list               
 az_news          update           node.az_news.az_media_list                      
 az_news          update           node.az_news.az_marquee                         
 az_news          update           node.az_news.az_feature                         
 az_news          update           node.az_news.az_card                            
 az_person        update           node.az_person.default                          
 az_publication   create           node.az_publication.az_card                     
 az_publication   create           AZ Publications Curate                          
 az_publication   update           node.az_publication.default                     
 az_publication   update           AZ Publications                                 
 node             update           Content                                         
 user             update           Anonymous user                                  
 user             update           Authenticated user                              
 az_quickstart    update           Content editor                                  
 az_quickstart    update           Content administrator                           
---------------- ---------------- ------------------------------------------------ 

(This existing site had az_publication already enabled.)

The ckeditor CKEditor 4 (contrib) (Deprecated) module showed up as enabled, likely because it has the same identifier as the old core equivalent that was in use prior to D10.

CK Editor still seemed to work for me, and had styles and embeds available.

[camikazegreen]

Confirming that the latest version has resolved the issue with editing News.