Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2442: Update drupal/bootstrap_barrio from 4.30 to 5.1.10. #2452

Merged
merged 3 commits into from
Jun 16, 2023

Conversation

joeparsons
Copy link
Member

@joeparsons joeparsons commented Jun 1, 2023

Description

Related issues

Closes #2442
Also needed for D10 compatibility (#2081)

How to test

  • General front end testing to make sure front-end theme still looks/works as expected
  • Test saving changes to theme settings form

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joeparsons joeparsons added enhancement New feature or request dependencies Pull requests that update a dependency file Drupal Waiting on a fix from the Drupal community 2.7.x only labels Jun 1, 2023
@joeparsons joeparsons self-assigned this Jun 1, 2023
@joeparsons joeparsons requested a review from a team as a code owner June 1, 2023 19:19
@joeparsons joeparsons mentioned this pull request Jun 1, 2023
4 tasks
@joeparsons joeparsons requested a review from a team June 1, 2023 19:33
@trackleft
Copy link
Member

trackleft commented Jun 1, 2023

FYI, there is a new select menu for "Load library"
https://058ca404-219d-4f91-88ae-7d128e43fce3.probo.build/user?destination=admin/appearance/settings/az_barrio
image

Additionally, the new setting is used if this module exists https://git.drupalcode.org/project/bootstrap_library

We should remove that setting in az_barrio.

@joeparsons
Copy link
Member Author

We should remove that setting in az_barrio.

Good catch @trackleft, thanks!

PR updated.

@joeparsons
Copy link
Member Author

joeparsons commented Jun 1, 2023

We should probably merge az-digital/arizona-bootstrap-packagist#20 together with this one.

Might be necessary to create a new Arizona Bootstrap release after doing so to take advantage of that change, though.

Copy link
Contributor

@joshuasosa joshuasosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to look and work ok all around. Note that if there's ever a decision to use Display Suite, either on an individual site or in the project, _bootstrap_barrio.layouts.yml may need to be copied over.

@joeparsons joeparsons merged commit aa28e85 into main Jun 16, 2023
@joeparsons joeparsons deleted the issue/2442 branch June 16, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.7.x only dependencies Pull requests that update a dependency file Drupal Waiting on a fix from the Drupal community enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade drupal/bootstrap_barrio to 5.1.x
4 participants