Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send logs to file #39

Closed
jamesbornholt opened this issue Jan 9, 2023 · 3 comments
Closed

Send logs to file #39

jamesbornholt opened this issue Jan 9, 2023 · 3 comments
Assignees
@eslrahc-swa
Labels
good first issue Good for newcomers
Milestone
Alpha (Public Rel...

Comments

@jamesbornholt
Copy link
Member

Currently we have no way to log to a file—logs are always printed to stderr. This is particularly annoying for metrics, which are spammed to the console every few seconds. We should have a way to redirect logs to a file. This will be more important once we do #30.
@jamesbornholt jamesbornholt added the good first issue Good for newcomers label Jan 9, 2023
@jamesbornholt jamesbornholt added this to the alpha milestone Jan 9, 2023
@dannycjones dannycjones mentioned this issue Jan 18, 2023
Merged
@dannycjones
Copy link
Contributor

dannycjones commented Jan 18, 2023 •
edited
Loading

We ask for logs as part of our bug report template (#56). We should update that template so its clear how to configure and enable log, likely just linking through to documentation.

@eslrahc-swa
Copy link
Contributor

High level goal:

  • segregate different log levels and makes it convenient to engineers for a better reasoning.

@monthonk monthonk mentioned this issue Feb 7, 2023
Merged
@dannycjones dannycjones mentioned this issue Feb 21, 2023
Closed
@jamesbornholt
Copy link
Member Author

#91

@dannycjones dannycjones mentioned this issue Jun 20, 2023
Closed
muddyfish added a commit to muddyfish/mountpoint-s3 that referenced this issue Sep 18, 2024
@muddyfish
Fix Empty Env varibales for STSWebIdentity (awslabs#246)
3b141d5 
Revert "Revert "Implement runtime check on libcrypto linkage (awslabs#186)" (awslabs#195)

Co-authored-by: WillChilds-Klein <[email protected]>
Bump the minimum stack size to at least 1MB (awslabs#1139)

BUILDER_VERSION: v0.9.55 (awslabs#66)

adapt change from "TLS deliver buffer data during shutdown" (awslabs#474)

Use const pointers in `secure_channel_tls_handler.c`. (awslabs#664)

Co-authored-by: Waqar Ahmed Khan <[email protected]>
Make options more const (awslabs#445)

Remove is ipv4/ipv6 functions utils from sdkutils to c-common (awslabs#39)

BUILDER_VERSION: v0.9.55 (awslabs#80)

Prepare release v1.32.0 (#1700)

### Description of changes:
Preparing for AWS-LC v1.32.0 release.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
Make `Dockerfile.source` actually build from source

- Dockerfile.source now builds based on centos:7
- Add `/` to path so you can run `mount-s3` without a /
- Adds `build-image` and `push-image` targets to makefile

Signed-off-by: Simon Beal <[email protected]>
chore: Bump Rust bindings v1.4.18 (#4656)
Signed-off-by: Simon Beal <[email protected]>
monthonk pushed a commit to monthonk/mountpoint-s3 that referenced this issue Oct 22, 2024
@passaro
Add append_object and implement it on the mock client (awslabs#39)
ad73cfa 
* Add append_object to MockClient

Signed-off-by: Alessandro Passaro <[email protected]>

* Add checksum validation

Signed-off-by: Alessandro Passaro <[email protected]>

* Address PR feedback

Signed-off-by: Alessandro Passaro <[email protected]>

---------

Signed-off-by: Alessandro Passaro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eslrahc-swa eslrahc-swa

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
Alpha (Public Release)
Development

No branches or pull requests
3 participants
@jamesbornholt @dannycjones @eslrahc-swa