Refactor metrics to have sharded shared state #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wanted to add some new metrics but they are gauges, and our current thread-local approach makes gauges hard -- each thread gets its own copy of the gauge. So instead, this change refactors the metrics infrastructure to have just one copy of each metric, stored in a sharded map to hopefully reduce contention. I didn't actually add any new metrics, so this should be a pure refactoring change. I beefed up the tests a little bit, too. Signed-off-by: James Bornholt <[email protected]>
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
jamesbornholt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
jamesbornholt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
jamesbornholt
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
Signed-off-by: James Bornholt <[email protected]>
jamesbornholt
force-pushed
the
metrics-shared
branch
from
354b12f to
297611d
Compare
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
dannycjones
requested review from
monthonk
and removed request for
dannycjones
Signed-off-by: James Bornholt <[email protected]>
jamesbornholt
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
jamesbornholt
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
approved these changes
Aug 16, 2023
muddyfish
added a commit
to muddyfish/mountpoint-s3
that referenced
this pull request
Sep 18, 2024
Revert "Revert "Implement runtime check on libcrypto linkage (awslabs#186)" (awslabs#195) Co-authored-by: WillChilds-Klein <[email protected]> Bump the minimum stack size to at least 1MB (awslabs#1139) BUILDER_VERSION: v0.9.55 (awslabs#66) adapt change from "TLS deliver buffer data during shutdown" (awslabs#474) Use const pointers in `secure_channel_tls_handler.c`. (awslabs#664) Co-authored-by: Waqar Ahmed Khan <[email protected]> Make options more const (awslabs#445) Remove is ipv4/ipv6 functions utils from sdkutils to c-common (awslabs#39) BUILDER_VERSION: v0.9.55 (awslabs#80) Prepare release v1.32.0 (#1700) ### Description of changes: Preparing for AWS-LC v1.32.0 release. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. Make `Dockerfile.source` actually build from source - Dockerfile.source now builds based on centos:7 - Add `/` to path so you can run `mount-s3` without a / - Adds `build-image` and `push-image` targets to makefile Signed-off-by: Simon Beal <[email protected]> chore: Bump Rust bindings v1.4.18 (#4656) Signed-off-by: Simon Beal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
I wanted to add some new metrics but they are gauges, and our current
thread-local approach makes gauges hard -- each thread gets its own copy
of the gauge. So instead, this change refactors the metrics
infrastructure to have just one copy of each metric, stored in a sharded
map to hopefully reduce contention.
I didn't actually add any new metrics, so this should be a pure
refactoring change. I beefed up the tests a little bit, too.
Does this change impact existing behavior?
No, refactoring only.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).