Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default logging to file by default #303

Closed
dannycjones opened this issue Jun 20, 2023 · 2 comments
Closed

Remove default logging to file by default #303

dannycjones opened this issue Jun 20, 2023 · 2 comments
Assignees
@dannycjones
Milestone
General Availabil...

Comments

@dannycjones
Copy link
Contributor

dannycjones commented Jun 20, 2023 •
edited
Loading

Logging to a file was configured in #39. By default, it logs to ~/.mountpoint-s3/.

In this issue, we'd like to consider what the default logging configuration should be to be unsurprising and safe for customers.
@dannycjones
Copy link
Contributor Author

It's probably surprising to customers that logs are being delivered to this directory, and the logs are not rotated.

The least surprising behavior would be to emit no logs to a file in --foreground mode, and allow it to be configured by customers using the existing --log-directory <path> option. We need to determine a good default for running in the background also - perhaps no logs today.

@dannycjones dannycjones changed the title Default logging configuration Remove default logging to file by default Jul 13, 2023
@dannycjones dannycjones self-assigned this Jul 13, 2023
@dannycjones dannycjones mentioned this issue Jul 13, 2023
Merged
@dannycjones
Copy link
Contributor Author

Completed in #373. Also, we added default syslog logging in #387.

passaro pushed a commit that referenced this issue Oct 28, 2024
@colinmarc
Allow users to create Notifier objects when handling requests (#303)
bbba3db 
* Allow users to create Notifier objects when handling requests

* Pass a Notifier to poll() implementations

This allows filesystems to respond directly to poll requests without
having saved a notifier at session creation time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dannycjones dannycjones

Labels
None yet
Projects
None yet
Milestone
General Availability (1.0)
Development

No branches or pull requests
1 participant
@dannycjones