Remove p384 restriction #4275
Merged
Remove p384 restriction #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to see whether this is still the case, and if so get more information about why it is happening.
goatgoose
reviewed
Nov 2, 2023
goatgoose
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
I never figured out why these restriction are added, but I am not seeing failures in CI after removing them.
#2130
Description of changes:
In the initial tests that I ran, this no longer seems to be an issue.
Testing:
If the CI passes then this should be good to merge.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.