Skip to content

Commit

Permalink
ci: add additional p-384 test coverage (#4275)
Browse files Browse the repository at this point in the history
  • Loading branch information
jmayclin authored Nov 6, 2023
1 parent 76ea8f8 commit 12a8ae3
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions tests/integrationv2/providers.py
Original file line number Diff line number Diff line change
Expand Up @@ -472,21 +472,6 @@ def supports_protocol(cls, protocol, with_cert=None):

@classmethod
def supports_cipher(cls, cipher, with_curve=None):
if "openssl-1.0.2" in get_flag(S2N_PROVIDER_VERSION) and with_curve is not None:
invalid_ciphers = [
Ciphers.ECDHE_RSA_AES128_SHA,
Ciphers.ECDHE_RSA_AES256_SHA,
Ciphers.ECDHE_RSA_AES128_SHA256,
Ciphers.ECDHE_RSA_AES256_SHA384,
Ciphers.ECDHE_RSA_AES128_GCM_SHA256,
Ciphers.ECDHE_RSA_AES256_GCM_SHA384,
]

# OpenSSL 1.0.2 and 1.0.2-FIPS can't find a shared cipher with S2N
# when P-384 is used, but I can't find any reason why.
if with_curve is Curves.P384 and cipher in invalid_ciphers:
return False

return True

def _is_openssl_11(self) -> None:
Expand Down

0 comments on commit 12a8ae3

Please sign in to comment.