Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove p384 restriction #4275

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Remove p384 restriction #4275

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fa4112
remove p-384 restriction
jmayclin Oct 31, 2023
ce19128
remove old unused definition
jmayclin Oct 31, 2023
01ca85b
Merge branch 'main' into remove-p384-restriction
jmayclin Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions tests/integrationv2/providers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,21 +472,6 @@ def supports_protocol(cls, protocol, with_cert=None):

@classmethod
def supports_cipher(cls, cipher, with_curve=None):
if "openssl-1.0.2" in get_flag(S2N_PROVIDER_VERSION) and with_curve is not None:
goatgoose marked this conversation as resolved.
Show resolved Hide resolved
invalid_ciphers = [
Ciphers.ECDHE_RSA_AES128_SHA,
Ciphers.ECDHE_RSA_AES256_SHA,
Ciphers.ECDHE_RSA_AES128_SHA256,
Ciphers.ECDHE_RSA_AES256_SHA384,
Ciphers.ECDHE_RSA_AES128_GCM_SHA256,
Ciphers.ECDHE_RSA_AES256_GCM_SHA384,
]

# OpenSSL 1.0.2 and 1.0.2-FIPS can't find a shared cipher with S2N
# when P-384 is used, but I can't find any reason why.
if with_curve is Curves.P384 and cipher in invalid_ciphers:
return False

return True

def _is_openssl_11(self) -> None:
Expand Down
Loading