Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cherry pick chart change v0.33.x #7297

Merged
merged 6 commits into from
Oct 29, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Oct 28, 2024

Fixes #N/A

Description
Templates karpenter-crd charts so that apiserver is able to correctly perform lookups if upgrading/installing to this version with webhooks disabled.

How was this change tested?
Webhook test suite.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rschalo rschalo marked this pull request as ready for review October 28, 2024 18:19
@rschalo rschalo requested a review from a team as a code owner October 28, 2024 18:19
@rschalo rschalo requested a review from danxwang22 October 28, 2024 18:19
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11560408526

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.815%

Totals Coverage Status
Change from base Build 11453271565: 0.0%
Covered Lines: 5349
Relevant Lines: 6874

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo merged commit 1747a33 into aws:release-v0.33.x Oct 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants