Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: chart snapshot for webhook test v0.37.x #7262

Merged
merged 3 commits into from
Oct 22, 2024
Merged

fix: chart snapshot for webhook test v0.37.x #7262

merged 3 commits into from
Oct 22, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Oct 21, 2024 •
edited
Loading

Fixes #N/A

Description
Testing CRD pin to use CRD where v1 has not been added.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rschalo rschalo requested a review from a team as a code owner October 21, 2024 23:30
@rschalo rschalo requested a review from tzneal October 21, 2024 23:30
@coveralls
Copy link

coveralls commented Oct 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11464572425

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.692%
Totals Coverage Status
Change from base Build 11453279448: 0.0%
Covered Lines: 5894
Relevant Lines: 7490
💛 - Coveralls

@rschalo rschalo changed the title fix: crd pinning for webhook test fix: crd pinning for webhook test v0.37.x Oct 21, 2024
@rschalo rschalo changed the title fix: crd pinning for webhook test v0.37.x fix: chart snapshot for webhook test v0.37.x Oct 22, 2024
@rschalo rschalo enabled auto-merge (squash) October 22, 2024 19:02
jonathan-innis
jonathan-innis approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo merged commit 94f277a into aws:release-v0.37.x Oct 22, 2024
13 checks passed
@rschalo rschalo deleted the pin-37-crd branch October 22, 2024 23:16
rschalo added a commit to rschalo/karpenter-provider-aws that referenced this pull request Oct 28, 2024
@rschalo
fix: chart snapshot for webhook test v0.37.x (aws#7262)
ab43b06
rschalo added a commit to rschalo/karpenter-provider-aws that referenced this pull request Oct 28, 2024
@rschalo
fix: chart snapshot for webhook test v0.37.x (aws#7262)
4698766
rschalo added a commit to rschalo/karpenter-provider-aws that referenced this pull request Oct 28, 2024
@rschalo
fix: chart snapshot for webhook test v0.37.x (aws#7262)
10e39c1
rschalo added a commit to rschalo/karpenter-provider-aws that referenced this pull request Oct 28, 2024
@rschalo
fix: chart snapshot for webhook test v0.37.x (aws#7262)
500332c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@tzneal tzneal Awaiting requested review from tzneal tzneal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rschalo @coveralls @jonathan-innis