Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Template v1 and Conversion CRD stanzas v0.37.x #7237

Merged
merged 9 commits into from
Oct 19, 2024
Merged

fix: Template v1 and Conversion CRD stanzas v0.37.x #7237

merged 9 commits into from
Oct 19, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Oct 16, 2024

Fixes #N/A

Description
Webhook E2Es failed because they were expecting to be able to find references to v1 during smoke test cleanup and could not.

How was this change tested?
Make e2etest

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rschalo rschalo requested a review from a team as a code owner October 16, 2024 23:07
@rschalo rschalo requested a review from bwagner5 October 16, 2024 23:07
@coveralls
Copy link

coveralls commented Oct 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11411588882

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 78.678%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.5%
Totals Coverage Status
Change from base Build 11355537696: -0.01%
Covered Lines: 5893
Relevant Lines: 7490
💛 - Coveralls

@rschalo rschalo changed the title fix: conditionally add conversion stanza to CRDs in test fix: Template v1 and conversion CRD stanzas v0.37.x Oct 18, 2024
@rschalo rschalo changed the title fix: Template v1 and conversion CRD stanzas v0.37.x fix: Template v1 and Conversion CRD stanzas v0.37.x Oct 18, 2024
jonathan-innis
jonathan-innis approved these changes Oct 19, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo merged commit 39718d7 into aws:release-v0.37.x Oct 19, 2024
14 checks passed
rschalo added a commit to rschalo/karpenter-provider-aws that referenced this pull request Oct 28, 2024
@rschalo
fix: Template v1 and Conversion CRD stanzas v0.37.x (aws#7237)
0b44aee
rschalo added a commit to rschalo/karpenter-provider-aws that referenced this pull request Oct 28, 2024
@rschalo
fix: Template v1 and Conversion CRD stanzas v0.37.x (aws#7237)
70c81a9
rschalo added a commit to rschalo/karpenter-provider-aws that referenced this pull request Oct 28, 2024
@rschalo
fix: Template v1 and Conversion CRD stanzas v0.37.x (aws#7237)
93f0e23
rschalo added a commit to rschalo/karpenter-provider-aws that referenced this pull request Oct 28, 2024
@rschalo
fix: Template v1 and Conversion CRD stanzas v0.37.x (aws#7237)
74e4ff6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engedaam engedaam engedaam left review comments

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rschalo @coveralls @jonathan-innis @engedaam