Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample Application Submission - Life Sciences / Molecular Modeling #484

Merged
merged 15 commits into from
May 12, 2023

Conversation

gkutchekAWS
Copy link
Contributor

Issue #, if available:
none

Description of changes:
Second submission for sample application after reflecting the previous feedback. Added a 05-Life-Sciences section to the sample application section to host the new 01-Modeling-Molecular-Structures-Graph-Data-Gremlin.ipnb notebook. Added section in the sample application read me & associated unit test for the new notebook.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

added in the life sciences section to serve as a home for the new sub-section of sample applications
added unit test for the new notebook & folder life-sciences
gkutchekAWS and others added 8 commits May 3, 2023 11:19
matching .READ_ME & overview files per unit test failures
Adding life sciences section to the overview.ipnb to match the read me per unit test failures
Removed space at the end of description - should match now
Adding in additional link for next steps section
matching to pass unit test - readme & sample applications overview diff
@gkutchekAWS
Copy link
Contributor Author

Hey I am a bit confused why these tests are failing as I am passing the tests all locally. Any insight into what might be going wrong here would be appreciated.

@joywa joywa self-assigned this May 11, 2023
Copy link
Contributor

@joywa joywa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelnchin michaelnchin merged commit 9e76139 into aws:main May 12, 2023
michaelnchin added a commit that referenced this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants