Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knowledge-graph-molecular-modeling #472

Conversation

gkutchekAWS
Copy link
Contributor

submitting my sample application notebook for a knowledge graph based around converting SMILES strings to graph data for review.

Issue #, if available:
None

Description of changes:
Adding in a sample notebook application for knowledge graph with molecular compounds.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

submitting my sample application notebook for a knowledge graph based around converting SMILES strings to graph data for review.
Copy link
Member

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gkutchekAWS , thank you for your contribution! The notebook looks great overall, and presents an excellent and unique use case.

A few general changes to request:

  1. Please clean up existing cell output content. To do this, open the notebook file in JupyterLab/Notebook -> Click "Kernel" in the menu bar -> Click "Restart & Clear Output". Then download the notebook as .ipynb file, and replace the one in your local graph-notebook repository.

  2. Please rename the notebook file to: 01-Molecular-Modeling-Blog.ipynb. This will bring it it in line with the naming scheme of the current Sample Applications notebooks.

  3. Move this molecular modeling notebook to its own directory, under 03-Sample-Applications. Create a new folder: ../03-Sample-Applications/05-Molecular-Modeling, and place the new notebook and an empty __init__.py file under this directory. In addition, please add a section with a brief description of this notebook to the Sample Applications README.

  4. Modify the unit tests to account for this new notebook, by adding the following line under line 42 in the notebooks validation test suite:

f'{NOTEBOOK_BASE_DIR}/03-Sample-Applications/05-Molecular-Modeling/01-Molecular-Modeling-Blog',

@michaelnchin
Copy link
Member

Closing in favor of revisions in #484.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants