-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set LicenseToken field only when version is greater than v0.22 #9264
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9264 +/- ##
=======================================
Coverage 72.35% 72.35%
=======================================
Files 587 587
Lines 46140 46140
=======================================
Hits 33385 33385
Misses 11006 11006
Partials 1749 1749 ☔ View full report in Codecov by Sentry. |
LicenseToken field on cluster spec will be introduced in 'v0.22.0'. At present since we set this field when initialize the end-to-end test object it gets set even on the previous minor versions where it's not intended to. This change sets this field only on main, or if the version is higher than 'v0.22.0'. This change also cleans up some old cleanup code in our e2e framework that was used only during way old releases such as 'v0.6.1' and is no longer needed. Signed-off-by: Rahul Ganesh <[email protected]>
354242c
to
cb34257
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2ez4szliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
#2855
Description of changes:
LicenseToken field on cluster spec will be introduced in 'v0.22.0'. At present since we set this field when initialize the end-to-end test object it gets set even on the previous minor versions where it's not intended to. This change sets this field only on main, or if the version is higher than 'v0.22.0'. This change also cleans up some old cleanup code in our e2e framework that was used only during way old releases such as 'v0.6.1' and is no longer needed.
Currently see the upgrade from latest minor version tests failing with the below error:
Testing (if applicable):
Verified that both simple flow and upgrade from minor flow works: https://tiny.amazon.com/14se0krtr/IsenLink
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.