Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set LicenseToken field only when version is greater than v0.22 #9264

Merged
merged 1 commit into from
Feb 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -265,4 +265,4 @@ reports:
e2e-reports:
files:
- reports/junit-testing-*.xml
file-format: "JUNITXML"
file-format: "JUNITXML"
5 changes: 5 additions & 0 deletions test/e2e/side_effects.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ func runFlowUpgradeManagementClusterCheckForSideEffects(test *framework.Multiclu
printStateOfMachines(test.ManagementCluster.ClusterConfig.Cluster, preUpgradeWorkloadClustersState)

test.T.Logf("Upgrading management cluster with EKS-A version %s", newEKSA.Version())

// Since we do not generate cluster config from the new binary and update the existing cluster config,
// we will need to manually add the license token for upgrade tests as long as the latest minor is 'v0.21.*'.
licenseToken := os.Getenv(framework.LicenseTokenEnvVar)
test.ManagementCluster.ClusterConfig.Cluster.Spec.LicenseToken = licenseToken
test.ManagementCluster.UpgradeClusterWithNewConfig(clusterOpts, framework.ExecuteWithBinary(newEKSA))

checker := machineSideEffectChecker{
Expand Down
17 changes: 0 additions & 17 deletions test/framework/api.go

This file was deleted.

28 changes: 21 additions & 7 deletions test/framework/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ const (
hardwareCsvPath = "hardware.csv"
EksaPackagesInstallation = "eks-anywhere-packages"
bundleReleasePathFromArtifacts = "./eks-anywhere-downloads/bundle-release.yaml"
releaseV022 = "v0.22.0"
)

//go:embed testdata/oidc-roles.yaml
Expand Down Expand Up @@ -144,11 +145,6 @@ func NewClusterE2ETest(t T, provider Provider, opts ...ClusterE2ETestOpt) *Clust

e.ClusterConfigLocation = filepath.Join(e.ClusterConfigFolder, e.ClusterName+"-eks-a.yaml")

licenseToken := getLicenseToken()
if licenseToken != "" {
e.clusterFillers = append(e.clusterFillers, api.WithLicenseToken(licenseToken))
}

if err := os.MkdirAll(e.ClusterConfigFolder, os.ModePerm); err != nil {
t.Fatalf("Failed creating cluster config folder for test: %s", err)
}
Expand Down Expand Up @@ -357,6 +353,10 @@ type Provider interface {
}

func (e *ClusterE2ETest) GenerateClusterConfig(opts ...CommandOpt) {
licenseToken := getLicenseToken()
if licenseToken != "" {
e.clusterFillers = append(e.clusterFillers, api.WithLicenseToken(licenseToken))
}
e.GenerateClusterConfigForVersion("", opts...)
}

Expand Down Expand Up @@ -481,9 +481,23 @@ func (e *ClusterE2ETest) generateHardwareConfig(opts ...CommandOpt) {
func (e *ClusterE2ETest) GenerateClusterConfigForVersion(eksaVersion string, opts ...CommandOpt) {
e.generateClusterConfigObjects(opts...)
if eksaVersion != "" {
err := cleanUpClusterForVersion(e.ClusterConfig, eksaVersion)
// LicenseToken field was introduced in cluster spec only in release-22
// attempting to populate the field for any prior versions would break the api.
// We will need the conditional check as long as the latest minor is 'v0.21.*'.
currentSemver, err := semver.New(eksaVersion)
if err != nil {
e.T.Fatal(err)
e.T.Fatal("parsing esk-a version", err)
}
semverV022, err := semver.New(releaseV022)
if err != nil {
e.T.Fatal("parsing esk-a version", err)
}

if currentSemver.Compare(semverV022) != -1 {
licenseToken := getLicenseToken()
if licenseToken != "" {
e.clusterFillers = append(e.clusterFillers, api.WithLicenseToken(licenseToken))
}
}
}

Expand Down
Loading