Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(manifest): add auto scaling options #1353

Merged
merged 3 commits into from
Sep 2, 2020
Merged

chore(manifest): add auto scaling options #1353

merged 3 commits into from
Sep 2, 2020

Conversation

iamhopaul123
Copy link
Contributor

Part of #1349.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@iamhopaul123 iamhopaul123 requested a review from a team as a code owner September 1, 2020 21:39
bvtujo
bvtujo approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@bvtujo bvtujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Looks really good.

internal/pkg/manifest/lb_web_svc.go Show resolved Hide resolved
internal/pkg/manifest/lb_web_svc_test.go Outdated Show resolved Hide resolved
efekarakus
efekarakus reviewed Sep 2, 2020
View reviewed changes
Copy link
Contributor

@efekarakus efekarakus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of having "chore" in the PR title? While this does make it possible to modify the manifest technically the feature is still not supported :P

internal/pkg/manifest/svc.go Outdated Show resolved Hide resolved
internal/pkg/manifest/svc.go Outdated Show resolved Hide resolved
internal/pkg/manifest/svc.go Show resolved Hide resolved
internal/pkg/manifest/svc.go Outdated Show resolved Hide resolved
internal/pkg/manifest/svc.go Outdated Show resolved Hide resolved
internal/pkg/manifest/svc.go Outdated Show resolved Hide resolved
@iamhopaul123 iamhopaul123 changed the title feat(manifest): add auto scaling options chore(manifest): add auto scaling options Sep 2, 2020
@mergify mergify bot merged commit a012157 into aws:mainline Sep 2, 2020
thrau pushed a commit to localstack/copilot-cli-local that referenced this pull request Dec 9, 2022
@iamhopaul123 @thrau
chore(manifest): add auto scaling options (aws#1353)
3948685 
<!-- Provide summary of changes -->
Part of aws#1349.
<!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efekarakus efekarakus efekarakus approved these changes

@bvtujo bvtujo bvtujo approved these changes

@huanjani huanjani Awaiting requested review from huanjani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamhopaul123 @efekarakus @bvtujo