Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto Scaling Milestone I #1349

Closed
4 tasks done
iamhopaul123 opened this issue Aug 31, 2020 · 0 comments
Closed
4 tasks done

Auto Scaling Milestone I #1349

iamhopaul123 opened this issue Aug 31, 2020 · 0 comments
Assignees
@iamhopaul123
Labels
type/design Issues that are design proposals.

Comments

@iamhopaul123
Copy link
Contributor

iamhopaul123 commented Aug 31, 2020 •
edited
Loading

Description

First milestone for #1154. Including Simple target tracking (without step scaling for SQS queue).

Schedule

  • Update manifest
  • Update CFN template
  • Custom resource lambda function that overrides desired count to autoscaling count during deployments
  • Allow svc status to show alarms created by auto scaling
@iamhopaul123 iamhopaul123 added the type/design Issues that are design proposals. label Aug 31, 2020
@iamhopaul123 iamhopaul123 self-assigned this Aug 31, 2020
@iamhopaul123 iamhopaul123 mentioned this issue Sep 1, 2020
Merged
mergify bot pushed a commit that referenced this issue Sep 2, 2020
@iamhopaul123
chore(manifest): add auto scaling options (#1353)
a012157 
<!-- Provide summary of changes -->
Part of #1349.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
@iamhopaul123 iamhopaul123 mentioned this issue Sep 2, 2020
Merged
mergify bot pushed a commit that referenced this issue Sep 3, 2020
@iamhopaul123
chore(stack): add auto scaling (#1354)
b4868cc 
<!-- Provide summary of changes -->
Part of #1349. Update `stack` pkg to pass Auto Scaling configs to CFN template.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
@iamhopaul123 iamhopaul123 mentioned this issue Sep 3, 2020
Merged
mergify bot pushed a commit that referenced this issue Sep 4, 2020
@iamhopaul123
feat(templates): enable autoscaling for simple target track policies (#…
3ce45ff 
…1355)

<!-- Provide summary of changes -->
Part of #1349. Enable Auto Scaling for simple target track policies by updating CFN template. Will add e2e test in a separate PR after this one. Also will add a custom resource to set `desiredCount` smartly so that when users update their ECS service there won't be a sudden increment/decrement to their task num.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
@iamhopaul123 iamhopaul123 mentioned this issue Sep 10, 2020
Merged
mergify bot pushed a commit that referenced this issue Sep 16, 2020
@iamhopaul123
feat(autoscaling): override desired count to autoscaling count during…
1fe8408 
… deployments (#1371)

Part of #1349. Add custom resource lambda function so that we can delegate desired count smartly. By default when a service is deployed for the first time, we take either the desired count specify by the user or the minimum value of their auto scaling range (if exists) as the ECS service desired count. When they update their service, we detect their current running copies and set the ECS service desired count to remain the same, so as to avoid users having this issue aws/containers-roadmap#493.

<!-- Provide summary of changes -->

<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thrau pushed a commit to localstack/copilot-cli-local that referenced this issue Dec 9, 2022
@iamhopaul123 @thrau
chore(manifest): add auto scaling options (aws#1353)
3948685 
<!-- Provide summary of changes -->
Part of aws#1349.
<!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thrau pushed a commit to localstack/copilot-cli-local that referenced this issue Dec 9, 2022
@iamhopaul123 @thrau
chore(stack): add auto scaling (aws#1354)
630ed7c 
<!-- Provide summary of changes -->
Part of aws#1349. Update `stack` pkg to pass Auto Scaling configs to CFN template.
<!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thrau pushed a commit to localstack/copilot-cli-local that referenced this issue Dec 9, 2022
@iamhopaul123 @thrau
feat(templates): enable autoscaling for simple target track policies (a…
74107be 
…ws#1355)

<!-- Provide summary of changes -->
Part of aws#1349. Enable Auto Scaling for simple target track policies by updating CFN template. Will add e2e test in a separate PR after this one. Also will add a custom resource to set `desiredCount` smartly so that when users update their ECS service there won't be a sudden increment/decrement to their task num.
<!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thrau pushed a commit to localstack/copilot-cli-local that referenced this issue Dec 9, 2022
@iamhopaul123 @thrau
feat(autoscaling): override desired count to autoscaling count during…
d031d22 
… deployments (aws#1371)

Part of aws#1349. Add custom resource lambda function so that we can delegate desired count smartly. By default when a service is deployed for the first time, we take either the desired count specify by the user or the minimum value of their auto scaling range (if exists) as the ECS service desired count. When they update their service, we detect their current running copies and set the ECS service desired count to remain the same, so as to avoid users having this issue aws/containers-roadmap#493.

<!-- Provide summary of changes -->

<!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamhopaul123 iamhopaul123

Labels
type/design Issues that are design proposals.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iamhopaul123