[EKS] [request]: Support tagging underlying ASGs of node groups

[richardchen-db]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Tell us about your request
It would be great if we could pass tags to the underlying ASGs (and tell the ASGs to propagate tags) that are created from the managed node groups for EKS.

Which service(s) is this request for?
EKS

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
Many organizations require tagging ASGs for cost and compliance reason (example here and here. In order to comply with organization policy, we had to either manually add them or using some workaround. It would be great if EKS officially supports it.

Are you currently working around this issue?
Yes. I created a working prototype using cluster api provider aws to automatically add the tags after node group creation.

Additional context
Anything else we should know?

Attachments
If you think you might have additional information that you'd like to include via an attachment, please do - we'll take a look. (Remember to remove any personally-identifiable information.)

[pc-mreeves]

Personally I'd like to see the tags set in Cloudformation for the AWS::EKS::Nodegroup be propagated to the ASGs because the node group manages the ASG for you.

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-eks-nodegroup.html#cfn-eks-nodegroup-tags

The ec2 tagging is taken care of by the LaunchTemplate using this: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-launchtemplate-tagspecification.html.

[migueleliasweb]

Another possible usecase for this: Without this feature using node label hinting, scale up priority or even disabling the cluster autoscaler is almost impossible as it relies on ASGs to be tagged so they can be autodiscovered.

https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/aws/README.md#auto-discovery-setup

[ThiyaguE]

I've tag based cost optimisation and governance controls; I use launchtemplate versions to update/upgrade eks nodegroup.
As updated tags keys, mentioned in new launchtemplate version is not propagating to ASG, instances are being created with obsolete tag key/values.. manual tagging is not an option for me.
As EKS controls nodegroup ASG and its launchtemplate, aws has to do something here.

[maxsxu]

Another similar request: #608