Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EKS: Support tagging node group's underlying ASG #2881

Closed
richardchen331 opened this issue Oct 26, 2021 · 5 comments · Fixed by #2884
Closed

EKS: Support tagging node group's underlying ASG #2881

richardchen331 opened this issue Oct 26, 2021 · 5 comments · Fixed by #2884
Assignees
@richardchen331
Labels
area/provider/eks Issues or PRs related to Amazon EKS provider help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@richardchen331
Copy link
Contributor

/kind feature

Describe the solution you'd like
There is an open issue on EKS where EKS doesn’t support tagging the underlying ASGs, however it’s quite important for many organizations for compliance, cost. It would be great to add such support in CAPA, where user can specify an optional AdditionalAsgTags field in AWSManagedMachinePool and the node group controller will reconcile the underlying ASG tags.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 26, 2021
@sedefsavas
Copy link
Contributor

We have additionalTags in AWSMachinePool, so I think this makes sense for AWSManagedMachinePool too.
/triage accepted
/help
/milestone v1.1.0

@k8s-ci-robot
Copy link
Contributor

@sedefsavas:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

We have additionalTags in AWSMachinePool, so I think this makes sense for AWSManagedMachinePool too.
/triage accepted
/help
/milestone v1.1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Oct 26, 2021
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 26, 2021
@sedefsavas
Copy link
Contributor

sedefsavas commented Oct 26, 2021 •
edited
Loading

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority labels Oct 26, 2021
@sedefsavas
Copy link
Contributor

/area provider/eks

@k8s-ci-robot k8s-ci-robot added the area/provider/eks Issues or PRs related to Amazon EKS provider label Oct 26, 2021
@richardchen331
Copy link
Contributor Author

/assign

@richardchen331 richardchen331 mentioned this issue Oct 27, 2021
Merged
4 tasks
@randomvariable randomvariable modified the milestones: v1.1.0, v1.2.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardchen331 richardchen331

Labels
area/provider/eks Issues or PRs related to Amazon EKS provider help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

EKS: Support tagging node group's underlying ASG richardchen331/cluster-api-provider-aws
4 participants
@richardchen331 @randomvariable @k8s-ci-robot @sedefsavas