feat: disable ASG AZRebalance of EKS by default #127
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
By default AWS rebalance the auto-scaling groups when there are are more nodes in one zone than the other. For Kubernetes clusters where there is already a Cluster Autoscaler operating the AutoScalingGroup (ASG) it could have some undesired effects.
Example there is an unbalanced ASG, but cluster autoscaler removes a node in the zone or add a new node in the unbalanced zone (which will balance again the number of machines), it can result in the two mechanisms take corrective actions at the same time provoking an unexpected result.
Ideally, we have only one controller that decides when to expand or shrink the node pool.
Modifications
terraform_data
resourceVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)
References
Currently, AWS doesn't support manipulate the ASGs implicitly created by EKS managed Node Groups. There are some related discussions: