Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed Auto Scaling Group resources do not receive all specified tags #1063

Closed
constantinevitt opened this issue Oct 17, 2022 · 1 comment
Closed
Labels
question Further information is requested

Comments

@constantinevitt
Copy link

Description

Using the example provided for EKS Managed Node Groups the actual Auto Scaling Groups which are created do not receive all tags which are defined in either the local.tags block on line 45 or the additional_tags block(s), for example on line 173

Other resources, such as instances and security groups do receive the relevant tags.

Versions

  • Module version [Required]:

  • Terraform version:

Terraform v1.3.2
on linux_amd64
  • Provider version(s):
+ provider registry.terraform.io/gavinbunney/kubectl v1.14.0
+ provider registry.terraform.io/hashicorp/aws v4.34.0
+ provider registry.terraform.io/hashicorp/cloudinit v2.2.0
+ provider registry.terraform.io/hashicorp/helm v2.7.1
+ provider registry.terraform.io/hashicorp/kubernetes v2.14.0
+ provider registry.terraform.io/hashicorp/local v2.2.3
+ provider registry.terraform.io/hashicorp/null v3.1.1
+ provider registry.terraform.io/hashicorp/time v0.9.0
+ provider registry.terraform.io/hashicorp/tls v3.4.0
+ provider registry.terraform.io/terraform-aws-modules/http v2.4.1

Reproduction Code [Required]

https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/examples/node-groups/managed-node-groups/main.tf

Steps to reproduce the behavior:

Run the above example
Check ASG tags via AWS console or cli

Expected behaviour

AWS autoscaling groups receive tags as defined by
https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/examples/node-groups/managed-node-groups/main.tf#L45

Actual behaviour

Auto Scaling Groups receive only standard EKS tags
image

Terminal Output Screenshot(s)

Additional context

@constantinevitt constantinevitt changed the title Auto Scaling Group resources do not receive all specified tags Managed Auto Scaling Group resources do not receive all specified tags Oct 17, 2022
@bryantbiggs bryantbiggs added the question Further information is requested label Oct 18, 2022
@bryantbiggs
Copy link
Contributor

Tags are only propagated when a custom launch template is used aws/containers-roadmap#1541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants