Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added builds on Docker images used by aws-c-cal. #117

Merged
merged 13 commits into from
Mar 25, 2021
Merged

Conversation

bryce-shang
Copy link
Contributor

@bryce-shang bryce-shang commented Mar 24, 2021

Issues:

Resolves CryptoAlg-663

Description of changes:

This PR added Docker images used by aws-c-cal. AWS-LC is built and tested on these environments. Specific changes:

  • Added scripts to pull aws crt Docker images from docker.pkg.github.com.
  • Refactored run-cdk.sh for better image build experience and parameters parser.
    • The new image build assumes CodeBuild and SSM runCommand result success status can indicate all images are pushed to ECR instead of checking images with aws ecr.
  • Added new script to run the minimal tests on aws-crt env.

Call-outs:

Testing:

See CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

bryce-shang and others added 10 commits March 1, 2021 14:21
* Pre-pull aws crt Docker images.

* Remove unused code.

* Address comments.

* Move common source.
* Pre-pull aws crt Docker images.

* Remove unused code.

* Run pull_github_pkg.sh in CodeBuild.

* Address comments.

* Move common source.

* Change README.md

* Address comments.
* Build and test without Perl/Go.

* Revert 'delete update-webhook cli'

* Fix typo.

* Adds build flavor -DBUILD_TESTING=0 -DBUILD_SSL=0.

* Adds build flavor -DBUILD_TESTING=0 -DBUILD_SSL=0 with release mode.

* Fix typo.

* Remove 'AWS_LC' prefix.

* Fix build flag.
@bryce-shang bryce-shang marked this pull request as draft March 24, 2021 18:42
@bryce-shang
Copy link
Contributor Author

This PR became draft because below error is being investigated.

Compiler version: Gcc4

Build dimension: run_build -DBUILD_TESTING=OFF -DBUILD_LIBSSL=OFF

Error:

aws-lc/crypto/fipsmodule/aes/aes_nohw.c:905:5: error: ‘for’ loop initial declarations are only allowed in C99 mode
--
116 | for (size_t j = 0; j < AES_NOHW_BATCH_SIZE; j++) {

@bryce-shang
Copy link
Contributor Author

bryce-shang commented Mar 24, 2021

This PR became draft because below error is being investigated.

Compiler version: Gcc4

Build dimension: run_build -DBUILD_TESTING=OFF -DBUILD_LIBSSL=OFF

Error:

aws-lc/crypto/fipsmodule/aes/aes_nohw.c:905:5: error: ‘for’ loop initial declarations are only allowed in C99 mode
--
116 | for (size_t j = 0; j < AES_NOHW_BATCH_SIZE; j++) {

For gcc-4x (default c mode is -std=gnu89), when run_build -DBUILD_TESTING=OFF -DBUILD_LIBSSL=OFF, CMAKE_COMPILER_IS_GNUCXX and c99 are not set because enable_language(CXX) is skipped. The current solution is to remove this build dimension but track via CryptoAlg-716 and CryptoAlg-718.

@bryce-shang
Copy link
Contributor Author

bryce-shang commented Mar 24, 2021

Discussed offline with andrewhop, BUILD_WITHOUT_GO and BUILD_WITHOUT_PERL are removed because we want to consider other Bssl build flags arts. This is tracked via CryptoAlg-717

@bryce-shang bryce-shang marked this pull request as ready for review March 24, 2021 22:44
@bryce-shang bryce-shang merged commit bc3d804 into main Mar 25, 2021
@bryce-shang bryce-shang deleted the aws-c-cal-ci branch May 3, 2021 23:58
WillChilds-Klein pushed a commit to WillChilds-Klein/aws-lc that referenced this pull request Mar 9, 2022
* Improve OpenSSL source acquisition
dkostic pushed a commit to dkostic/aws-lc that referenced this pull request Jul 22, 2024
Weierstrass point doubling improvements and bifurcation, other minor tweaks
s2n-bignum original commit: awslabs/s2n-bignum@8ec370c
torben-hansen pushed a commit to torben-hansen/aws-lc that referenced this pull request Sep 18, 2024
Weierstrass point doubling improvements and bifurcation, other minor tweaks
s2n-bignum original commit: awslabs/s2n-bignum@8ec370c
torben-hansen pushed a commit to torben-hansen/aws-lc that referenced this pull request Sep 18, 2024
Weierstrass point doubling improvements and bifurcation, other minor tweaks
s2n-bignum original commit: awslabs/s2n-bignum@8ec370c

s2n-bignum original commit: awslabs/s2n-bignum@73aa0bd
torben-hansen pushed a commit to torben-hansen/aws-lc that referenced this pull request Sep 19, 2024
Weierstrass point doubling improvements and bifurcation, other minor tweaks
s2n-bignum original commit: awslabs/s2n-bignum@8ec370c
dkostic pushed a commit to dkostic/aws-lc that referenced this pull request Dec 5, 2024
Weierstrass point doubling improvements and bifurcation, other minor tweaks
dkostic pushed a commit to dkostic/aws-lc that referenced this pull request Dec 10, 2024
Weierstrass point doubling improvements and bifurcation, other minor tweaks
s2n-bignum original commit: awslabs/s2n-bignum@8ec370c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants