Pre-pull aws crt Docker images. #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebeid
reviewed
Mar 3, 2021
| source "${parent_dir}/common.sh" | ||
|
|
||
| ################################# | ||
| # Sett up environment variables # |
There was a problem hiding this comment.
Addressed. Good catch.
|
|
||
| ## Docker image push. | ||
| To push to the ECR repository of default AWS account, run `push_images.sh`. | ||
| To push to the ECR repository pass in a complete ECS url `push_images.sh ${ACCOUNT_ID}.dkr.ecr.${REGION}.amazonaws.com/${REPOSITORY}`. |
There was a problem hiding this comment.
From what I understand, the handling of CRT images is different from the rest of the images, correct? Can this be briefly described here? CRT is Common Runtime?
There was a problem hiding this comment.
This README.md is overview of linux-x86 Docker images build. I added some crt related comments in aws-crt-common.sh.
nebeid
approved these changes
Mar 5, 2021
| # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| parent_dir="$(dirname -- "$(realpath -- "$file_name")")" |
There was a problem hiding this comment.
Is file_name not undefined?
There was a problem hiding this comment.
Removed. Move this source to upper dir.
# Test in aws-lc/tests/ci/docker_images/linux-x86
+++ dirname ./pull_github_pkg.sh
++ cd .
++ pwd
+ cur_dir=/home/ubuntu/bryce-shang/aws-lc/tests/ci/docker_images/linux-x86
+ source /home/ubuntu/bryce-shang/aws-lc/tests/ci/docker_images/linux-x86/common.sh
+ source /home/ubuntu/bryce-shang/aws-lc/tests/ci/docker_images/linux-x86/aws-crt/aws-crt-common.sh
# Test in aws-lc
+++ dirname ./tests/ci/docker_images/linux-x86/pull_github_pkg.sh
++ cd ./tests/ci/docker_images/linux-x86
++ pwd
+ cur_dir=/home/ubuntu/bryce-shang/aws-lc/tests/ci/docker_images/linux-x86
+ source /home/ubuntu/bryce-shang/aws-lc/tests/ci/docker_images/linux-x86/common.sh
+ source /home/ubuntu/bryce-shang/aws-lc/tests/ci/docker_images/linux-x86/aws-crt/aws-crt-common.sh
| # Pull Docker images used by https://github.com/awslabs/aws-c-cal | ||
| # These Docker images are hosted in 'docker.pkg.github.com', which needs GitHub personal access token. | ||
| cur_dir="$(cd "$(dirname "$0")" && pwd)" | ||
| # shellcheck source=./common.sh |
There was a problem hiding this comment.
What are these shellcheck comments for?
There was a problem hiding this comment.
https://github.com/koalaman/shellcheck
For bash scripts, some IDEs use shellcheck, which is a static analysis tool. # shellcheck is used to suppress the tool warning because the tool cannot check the runtime value (cur_dir).
andrew-kaufman
approved these changes
Mar 8, 2021
This was referenced Mar 24, 2021
bryce-shang
added a commit
that referenced
this pull request
Mar 25, 2021
* Pre-pull aws crt Docker images. * Remove unused code. * Run pull_github_pkg.sh in CodeBuild. * Update files under 'generated-src' dir. * Pre-pull aws crt Docker images. (#102) * Pre-pull aws crt Docker images. * Remove unused code. * Address comments. * Move common source. * Integrate pull script with CDK. (#103) * Pre-pull aws crt Docker images. * Remove unused code. * Run pull_github_pkg.sh in CodeBuild. * Address comments. * Move common source. * Change README.md * Address comments. * Build and test without Perl/Go. (#107) * Build and test without Perl/Go. * Revert 'delete update-webhook cli' * Fix typo. * Adds build flavor -DBUILD_TESTING=0 -DBUILD_SSL=0. * Adds build flavor -DBUILD_TESTING=0 -DBUILD_SSL=0 with release mode. * Fix typo. * Remove 'AWS_LC' prefix. * Fix build flag. * Add note. * Remove build with -DBUILD_TESTING=0 -DBUILD_SSL=0. * Remove build flags - BUILD_WITHOUT_GO and BUILD_WITHOUT_PERL..
dkostic
pushed a commit
to dkostic/aws-lc
that referenced
this pull request
Dec 5, 2024
Print running times of proofs, factor out proof runner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses CryptoAlg-663
Description of changes:
This PR adds scripts to pull aws crt Docker images from
docker.pkg.github.com.Call-outs:
Next PR #103 will integrate the scripts with CI setup code.
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.